Reduce bugs.webkit.org API calls#271
Open
gsnedders wants to merge 3 commits into
Open
Conversation
When almost all WebKit contributions are in GitHub PRs, looking at these flags on Bugzilla is near useless.
Instead of fetching bug details individually for each WebKit export PR, group them by bug ID and query for all bugs that have ever been marked FIXED in a single API call. This significantly reduces the number of API calls in the common case.
Serialize all bugs.webkit.org requests through a shared throttle so outgoing calls are spaced at least 1 second apart, regardless of caller. This protects bugs.webkit.org from accidental bursts (e.g. from the WebKit poller fanning out per-bug history fetches).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of polling each and every WebKit bug for every open GitHub PR, this instead uses a single query to fetch all bugs which have ever been marked as fixed. This has a significant impact on the number of requests made to the Bugzilla API, and should make it practical to enforce a rate limit which we previously did not have.
As a precursor to this, we also drop support for r+ and commit-queue+, given these are largely unused nowadays.