Commit 4809b72
[WebXR] Detect all frame owners in DOM Overlay
ProcessOverlayHitTest downcasts the hit element to HTMLFrameElementBase
to decide whether to walk the content frame subtree for cross-origin
content. That base class only covers <iframe> and <frame>; content
embedded via <object>, <embed>, or <fencedframe> owns a content frame
through HTMLFrameOwnerElement instead, so the cast returned null and
the cross-origin check was skipped.
Cast to HTMLFrameOwnerElement instead so every frame-owning element is
subject to the same origin check. Extend the ar_dom_overlay WPT with
an <object> variant of the existing cross-origin iframe test.
TAG=agy
Fixed: 524418836
Change-Id: I43830c7a669820dbb56c3a1792d9f7c6813d1c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8120459
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1665189}1 parent fdd9d8b commit 4809b72
1 file changed
Lines changed: 18 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
175 | 178 | | |
176 | 179 | | |
177 | 180 | | |
178 | | - | |
| 181 | + | |
179 | 182 | | |
180 | 183 | | |
181 | | - | |
182 | | - | |
| 184 | + | |
| 185 | + | |
183 | 186 | | |
184 | 187 | | |
185 | 188 | | |
| |||
198 | 201 | | |
199 | 202 | | |
200 | 203 | | |
201 | | - | |
202 | | - | |
| 204 | + | |
| 205 | + | |
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
| |||
289 | 292 | | |
290 | 293 | | |
291 | 294 | | |
292 | | - | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
293 | 304 | | |
294 | 305 | | |
295 | 306 | | |
| |||
0 commit comments