Commit eb50666
Revert "Use slot fallback to render optgroup label attr"
This reverts commit db609514c367c1018fccbea7e3e78c8036fc1ae4.
Reason for revert: Consistent test failures on Fuchsia bots due to accessibility tree expectation mismatches.
Affected tests include: - DumpAccessibilityTreeTest.AccessibilityComboboxOptgroup - DumpAccessibilityTreeTest.AccessibilityModalDialogClosed - DumpAccessibilityTreeTest.AccessibilityModalDialogOpened - DumpAccessibilityTreeTest.AccessibilityModalDialogStack - DumpAccessibilityTreeTest.AccessibilityOptgroup ... and others.
Failure Link:
https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-x64-cast-receiver-rel/30173/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-arm64-cast-receiver-rel/30278/test-results
Original change's description:
> Use slot fallback to render optgroup label attr
>
> Instead of setting display:none on the element which holds the label
> attribute when a legend element is present, we can put the label
> attribute holding element as a child of a new slot for the legend
> element, so it automatically gets rendered when there is no legend
> element.
>
> The legend element is only supposed to be the first element in the
> optgroup as per the content model in the HTML spec, so this patch also
> enforces that by only slotting the legend element in when it is the
> first child element. Allowing or using the legend element inside of
> optgroups was a new feature with customizable select, so compat risk is
> low.
>
> Context: whatwg/html#12201 (comment)
>
> There are a11y test expectations because the UA shadowroot is being
> changed, but this should not be visible to ATs because the new nodes are
> marked as invisible and ignored, and only appear in the internal "blink"
> a11y trees as opposed to real platform trees.
>
> Change-Id: I776fee963146abbad2028638479df7d3362c35ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7629416
> Reviewed-by: Joey Arhar <jarhar@chromium.org>
> Reviewed-by: David Baron <dbaron@chromium.org>
> Commit-Queue: Joey Arhar <jarhar@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1649235}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iae750043c09be7dede4b8fbea417995de96ec9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7961701
Owners-Override: Anna Sato <annasato@chromium.org>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Anna Sato <annasato@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1649473}1 parent 73abfd1 commit eb50666
2 files changed
Lines changed: 1 addition & 27 deletions
File tree
- html/semantics/forms/the-select-element/customizable-select
Lines changed: 0 additions & 22 deletions
This file was deleted.
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 26 | | |
31 | 27 | | |
32 | 28 | | |
| |||
0 commit comments