layout: Add initial support for text-overflow: ellipsis#56115
Closed
servo-wpt-sync wants to merge 1 commit into
Closed
layout: Add initial support for text-overflow: ellipsis#56115servo-wpt-sync wants to merge 1 commit into
text-overflow: ellipsis#56115servo-wpt-sync wants to merge 1 commit into
Conversation
wpt-pr-bot
approved these changes
Nov 19, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_40526
branch
from
afdc8db to
16ce041
Compare
servo-wpt-sync
changed the title
text-overflow: ellipsis
servo-wpt-sync
force-pushed
the
servo_export_40526
branch
from
16ce041 to
24a1fae
Compare
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
servo-wpt-sync
force-pushed
the
servo_export_40526
branch
from
24a1fae to
64afd0b
Compare
whimboo
requested changes
Nov 20, 2025
Contributor
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
These changes are only cached files and it should not land. Please remove it from the patch.
Contributor
|
I also made a comment over on servo/servo#40526 (review) where the review seems to actually take place. |
Collaborator
Author
|
👋 Downstream pull request (servo/servo#40526) no longer contains any upstreamable changes. Closing pull request without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout: Added basic
text-overflow: ellipsissupport at theFragment Tree&Display Listconstruction stages.This PR is an attempt to create a very basic support for
text-overflow: ellipsisaccording to the CSS specifications.I'd like to emphasize the word basic here, as this is a partial implementation only. For example, this PR doesn't add support for "double-valued"
text-overflow, such astext-overflow: ellipsis ellipsis.In addition to this, I have opened a PR in the Stylo repository #issue 270 and created a blog to explain my implementation.
Fixes: #40444
Reviewed in servo/servo#40526