webdriver: Improve error reporting for Cookie Addition#58773
Merged
servo-wpt-sync merged 1 commit intoMar 26, 2026
Conversation
wpt-pr-bot
approved these changes
Mar 26, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
servo-wpt-sync
force-pushed
the
servo_export_43690
branch
from
98dac8a to
3937ef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the error reporting for cookie addition.
Most notably, when
There is a bug with spec: servo/servo#43690 (comment).
We fix spec in w3c/webdriver#1955 and
make sure Servo behaves consistently with other browsers.
Testing: Added one test for invalid expiry time. New passing with existing.
Reviewed in servo/servo#43690