Skip to content

[wdspec] Fix before_request_sent.py cookie tests for Chrome #59305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliandescottes merged 1 commit into from
Apr 21, 2026
Merged

[wdspec] Fix before_request_sent.py cookie tests for Chrome #59305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions webdriver/tests/bidi/network/before_request_sent/before_request_sent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from urllib.parse import urlencode

import pytest
import pytest_asyncio

from webdriver.bidi.modules.script import ContextTarget

Expand All @@ -22,6 +23,11 @@
pytestmark = pytest.mark.asyncio


@pytest_asyncio.fixture(autouse=True)
async def delete_cookies(bidi_session):
await bidi_session.storage.delete_cookies()


async def test_subscribe_status(bidi_session, subscribe_events, top_context, wait_for_event, wait_for_future_safe, url, fetch):
await subscribe_events(events=[BEFORE_REQUEST_SENT_EVENT])

Expand Down Expand Up @@ -243,7 +249,6 @@ async def test_request_cookies(
"httpOnly": False,
"name": "foo",
"path": "/",
"sameSite": "default",
"secure": False,
"size": 6,
"value": {"type": "string", "value": "bar"},
Expand Down Expand Up @@ -274,7 +279,6 @@ async def test_request_cookies(
"httpOnly": False,
"name": "foo",
"path": "/",
"sameSite": "default",
"secure": False,
"size": 6,
"value": {"type": "string", "value": "bar"},
Expand All @@ -283,7 +287,6 @@ async def test_request_cookies(
"httpOnly": False,
"name": "fuu",
"path": "/",
"sameSite": "default",
"secure": False,
"size": 6,
"value": {"type": "string", "value": "baz"},
Expand All @@ -297,8 +300,6 @@ async def test_request_cookies(
expected_event={"request": expected_request, "redirectCount": 0},
)

await bidi_session.storage.delete_cookies()


async def test_request_cookie_same_name_different_host(
bidi_session,
Expand Down Expand Up @@ -351,7 +352,6 @@ async def test_request_cookie_same_name_different_host(
"httpOnly": False,
"name": "foo",
"path": "/webdriver/tests/bidi/network/support",
"sameSite": "default",
"secure": False,
"size": 6,
"value": {"type": "string", "value": "bar"},
Expand All @@ -365,8 +365,6 @@ async def test_request_cookie_same_name_different_host(
expected_event={"request": expected_request, "redirectCount": 0},
)

await bidi_session.storage.delete_cookies()


async def test_request_timing_info(
bidi_session,
Expand Down
Loading