[Gecko Bug 2028907] Part 2: Re-work tests that don't work with #wait-for-all.#59308
Merged
[Gecko Bug 2028907] Part 2: Re-work tests that don't work with #wait-for-all.#59308
Conversation
The issue is that when there are no intercept handlers, or the handlers provide a result immediately by returning or resolving/rejecting. This will mean that the reactions for committed and finished will run in the same microtask, which is correct according to spec. Differential Revision: https://phabricator.services.mozilla.com/D291776 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2028907 gecko-commit: 289586a1a04ef5ebb259721340de41f5ecdd92cd gecko-commit-git: ebed8d507ea5c9740c9916d9b5a7aef7f11b3fa1 gecko-reviewers: dom-core, jjaschke
wpt-pr-bot
approved these changes
Apr 17, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Contributor
Contributor
Contributor
|
I see that this closed without merging @farre ? |
Contributor
|
I don't know. @jgraham do you? |
foolip
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that when there are no intercept handlers, or the handlers
provide a result immediately by returning or resolving/rejecting. This
will mean that the reactions for committed and finished will run in the
same microtask, which is correct according to spec.
Differential Revision: https://phabricator.services.mozilla.com/D291776
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2028907
gecko-commit: 289586a1a04ef5ebb259721340de41f5ecdd92cd
gecko-commit-git: ebed8d507ea5c9740c9916d9b5a7aef7f11b3fa1
gecko-reviewers: dom-core, jjaschke