Split 2d-invalid-size-context-lost.html into test variants#59313
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Apr 19, 2026
Merged
Split 2d-invalid-size-context-lost.html into test variants#59313chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
With this change, each canvas types (HTMLCanvasElement, OffscreenCanvas, offscreen + placeholder, etc.) run into different test instances. This makes each of these instances run faster (potentially avoiding timeouts). This will also be useful in a follow-up CL (https://crrev.com/c/7770807), where tests will be added to validate GPU process loss. Tests are normally running one after the other, so an individual test can kill and restore the GPU process without impacting the others. But this is not true for worker tests because workers run in a parallel thread. Killing the GPU process in the main thread would break the test running in the worker. The solution to this is to run the workers in a different variant, which will either run with a different test runner, or before/after other variants. Change-Id: I95ec34c070d0908e687b5d7c8d207c2e012f585e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7770727 Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1617255}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7770727
branch
from
ae6d85c to
6943f68
Compare
wpt-pr-bot
approved these changes
Apr 19, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, each canvas types (HTMLCanvasElement, OffscreenCanvas,
offscreen + placeholder, etc.) run into different test instances. This
makes each of these instances run faster (potentially avoiding
timeouts). This will also be useful in a follow-up CL
(https://crrev.com/c/7770807), where tests will be added to validate GPU
process loss. Tests are normally running one after the other, so an
individual test can kill and restore the GPU process without impacting
the others. But this is not true for worker tests because workers run in
a parallel thread. Killing the GPU process in the main thread would
break the test running in the worker. The solution to this is to run the
workers in a different variant, which will either run with a different
test runner, or before/after other variants.
Change-Id: I95ec34c070d0908e687b5d7c8d207c2e012f585e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7770727
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617255}