Sanitizer API: Improve coverage#59323
Open
JKingweb wants to merge 3 commits intoweb-platform-tests:masterfrom
Open
Sanitizer API: Improve coverage#59323JKingweb wants to merge 3 commits intoweb-platform-tests:masterfrom
JKingweb wants to merge 3 commits intoweb-platform-tests:masterfrom
Conversation
Member
Yeah, we struggled a bit with this: Event content handler attributes is a spec-defined term. The expectation is that when browsers introduce new event handlers that haven't made it into the spec yet, they'll also handle those. The current draft for the HTML spec goes further and just lists them. I think that gives us plenty examlpes to test against. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improve the coverage of the Sanitizer API
Sanitizerobject tests in a few areas:allowElement()with a data attribute when data attributes are already allowedsetDataAttributes(),setComments()andremoveUnsafe()(Chromium fails here)attributesandelementslists when callingsetDataAttributes(true)attributesandelementslists when callingremoveUnsafe()The last of these might need to be changed because it tests something which is implementation-defined (event content attributes). I tried to pick attributes which wouldn't rely on a particular input method or anything but basic scripting features, though.