Unflake new-scroll-event-dispatched-at-next-updating-rendering-time.html in Safari#59330
Merged
Unflake new-scroll-event-dispatched-at-next-updating-rendering-time.html in Safari#59330
Conversation
…tml in Safari The assertion related to the main bug measuring the timeOnTransitionRun relative to the timeOnScrollEvent is always passing in Safari. The MQ listener happens occasionally too quickly and performance.now() ends up equal for both the scroll event and the MQ listener. This causes a flaky test failure in Safari. Make the test more flexible by allowing the timestamps to be equal.
Member
Author
Contributor
|
Thanks! It looks good to me. Unfortunately I don't have the permission to merge this change. @jgraham would you mind doing it for me? Thanks! (Or maybe this change also needs to be reviewed by someone in the interop group other than Tim?) |
aethanyc
approved these changes
Apr 20, 2026
Contributor
aethanyc
left a comment
aethanyc
left a comment
There was a problem hiding this comment.
Approve for Hiro per #59330 (comment)
jgraham
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion related to the main bug measuring the timeOnTransitionRun relative to the timeOnScrollEvent is always passing in Safari.
The MQ listener happens occasionally too quickly and performance.now() ends up equal for both the scroll event and the MQ listener. This causes a flaky test failure in Safari. Make the test more flexible by allowing the timestamps to be equal.