WebMCP: Implement tool name validation#59676
Merged
Merged
Conversation
The spec PR webmachinelearning/webmcp#152 is tightening tool name validation to match what the MCP specification accepts [1], and we think it's reasonable for the web platform to throw exceptions when tool names do not match this criteria, which is what this CL does. [1]: https://modelcontextprotocol.io/specification/2025-11-25/server/tools#tool-names R=masonf Bug: 489045948 Change-Id: I7d1af5d8cd18e5be7db5ddc9f9ce6d28e73cfd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744064 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1625865}
8ba5403 to
296d54d
Compare
wpt-pr-bot
approved these changes
May 6, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec PR webmachinelearning/webmcp#152 is
tightening tool name validation to match what the MCP specification
accepts 1, and we think it's reasonable for the web platform to throw
exceptions when tool names do not match this criteria, which is what
this CL does.
R=masonf
Bug: 489045948
Change-Id: I7d1af5d8cd18e5be7db5ddc9f9ce6d28e73cfd3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744064
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1625865}