Two sandboxed iframes are in different agent clusters#60311
Open
annevk wants to merge 1 commit into
Open
Conversation
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Jun 1, 2026
https://bugs.webkit.org/show_bug.cgi?id=216618 rdar://69452369 Reviewed by NOBODY (OOPS!). This implements origin-keyed agent clusters and gates it behind OriginAgentClusterEnabled (set to preview). It is standardized here: https://html.spec.whatwg.org/multipage/browsers.html#origin-isolation This new keying does not impact process allocation, although we could decide to make it impact that in the future if we wanted to. It impacts document.domain, serialization and deserialization of certain objects, and the new window.originAgentCluster getter. We add a new test that is upstreamed at web-platform-tests/wpt#60311 that catches an issue with our existing agent cluster implementation for opaque origins and we also fix that issue. As the test infrastructure continues to use the same browsing context group for each test, we add a way to reset the browsing context group state so it appears as if you are getting a fresh browsing context group when you start a new test. The subtest failures of regression-1399759.https.sub.html are due to about:blank inheriting from the parent instead of the initiator of the navigation. That's a distinct issue from this new feature. going-back.sub.https.html is skipped because it times out on some bots at the history.back() step, while the feature-related assertions pass. I suspect it's related to the bfcache. I could not reproduce it locally (1000 iterations of the test as well as 10 full-directory runs).
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Jun 1, 2026
https://bugs.webkit.org/show_bug.cgi?id=216618 rdar://69452369 Reviewed by NOBODY (OOPS!). This implements origin-keyed agent clusters and gates it behind OriginAgentClusterEnabled (set to preview). It is standardized here: https://html.spec.whatwg.org/multipage/browsers.html#origin-isolation This new keying does not impact process allocation, although we could decide to make it impact that in the future if we wanted to. It impacts document.domain, serialization and deserialization of certain objects, and the new window.originAgentCluster getter. We add a new test that is upstreamed at web-platform-tests/wpt#60311 that catches an issue with our existing agent cluster implementation for opaque origins and we also fix that issue. As the test infrastructure continues to use the same browsing context group for each test, we add a way to reset the browsing context group state so it appears as if you are getting a fresh browsing context group when you start a new test. The subtest failures of regression-1399759.https.sub.html are due to about:blank inheriting from the parent instead of the initiator of the navigation. That's a distinct issue from this new feature. going-back.sub.https.html is skipped because it times out on some bots at the history.back() step, while the feature-related assertions pass. I suspect it's related to the bfcache. I could not reproduce it locally (1000 iterations of the test as well as 10 full-directory runs).
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Jun 2, 2026
https://bugs.webkit.org/show_bug.cgi?id=216618 rdar://69452369 Reviewed by NOBODY (OOPS!). This implements origin-keyed agent clusters and gates it behind OriginAgentClusterEnabled (set to preview). It is standardized here: https://html.spec.whatwg.org/multipage/browsers.html#origin-isolation This new keying does not impact process allocation, although we could decide to make it impact that in the future if we wanted to. It impacts document.domain, serialization and deserialization of certain objects, and the new window.originAgentCluster getter. We add a new test that is upstreamed at web-platform-tests/wpt#60311 that catches an issue with our existing agent cluster implementation for opaque origins and we also fix that issue. As the test infrastructure continues to use the same browsing context group for each test, we add a way to reset the browsing context group state so it appears as if you are getting a fresh browsing context group when you start a new test. The subtest failures of regression-1399759.https.sub.html are due to about:blank inheriting from the parent instead of the initiator of the navigation. That's a distinct issue from this new feature. going-back.sub.https.html is skipped because it times out on some bots at the history.back() step, while the feature-related assertions pass. I suspect it's related to the bfcache. I could not reproduce it locally (1000 iterations of the test as well as 10 full-directory runs).
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Jun 2, 2026
https://bugs.webkit.org/show_bug.cgi?id=216618 rdar://69452369 Reviewed by Alex Christensen. This implements origin-keyed agent clusters and gates it behind OriginAgentClusterEnabled (set to preview). It is standardized here: https://html.spec.whatwg.org/multipage/browsers.html#origin-isolation This new keying does not impact process allocation, although we could decide to make it impact that in the future if we wanted to. It impacts document.domain, serialization and deserialization of certain objects, and the new window.originAgentCluster getter. We add a new test that is upstreamed at web-platform-tests/wpt#60311 that catches an issue with our existing agent cluster implementation for opaque origins and we also fix that issue. As the test infrastructure continues to use the same browsing context group for each test, we add a way to reset the browsing context group state so it appears as if you are getting a fresh browsing context group when you start a new test. The subtest failures of regression-1399759.https.sub.html are due to about:blank inheriting from the parent instead of the initiator of the navigation. That's a distinct issue from this new feature. going-back.sub.https.html is skipped because it times out on some bots at the history.back() step, while the feature-related assertions pass. I suspect it's related to the bfcache. I could not reproduce it locally (1000 iterations of the test as well as 10 full-directory runs). Canonical link: https://commits.webkit.org/314346@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.