Skip to content

Expect getTargetRanges() to be non-empty for DOM-based EditContext. #60326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ltenmoz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expect getTargetRanges() to be non-empty for DOM-based EditContext. #60326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 60 additions & 9 deletions editing/edit-context/edit-context-input.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
</head>
<body>
<script>
const kBackspaceKey = "\uE003";
const kDeleteKey = "\uE017";
const kBackspaceKey = "\uE003";
const kDeleteKey = "\uE017";
// Modifier key to use with backspace/delete to delete words.
const kModifierKey = navigator.platform.indexOf("Mac") === 0 ? "\uE00A" : "\uE009";

async function testBasicTestInput(element) {
const editContext = new EditContext();
Expand Down Expand Up @@ -132,6 +134,16 @@
div.remove();
}, "EditContext should not receive events after being detached from element");

function checkTargetRanges(element, ranges, expected, key) {
if (element.tagName === "CANVAS") {
assert_equals(ranges.length, 0, key + " beforeinput should not have a target range in canvas EditContext");
} else {
assert_equals(ranges.length, 1, key + " beforeinput should have exactly one target range in DOM-based EditContext");
assert_array_equals(ranges[0], expected,
key + " beforeinput target range has incorrect offsets");
}
}

async function testBackspaceAndDelete(element) {
const editContext = new EditContext();
let textForView = "hello there";
Expand All @@ -151,19 +163,50 @@
element.editContext = editContext;
editContext.updateText(0, 11, "hello there");
editContext.updateSelection(10, 10);
const selection = window.getSelection();

if (element.tagName !== "CANVAS") {
// put selection in a text node which doesn't actually reflect editContext.text
let selectionTextNode = document.createTextNode("abcd");
element.append(selectionTextNode);
getSelection().collapse(selectionTextNode, 2);
}

await test_driver.send_keys(element, kBackspaceKey);
assert_equals(textForView, "hello thee");
assert_array_equals(textUpdateSelection, [9, 9]);
assert_equals(beforeInputType, "deleteContentBackward");
assert_equals(beforeInputTargetRanges.length, 0, "Backspace should not have a target range in EditContext");
// Target range should be based on DOM, not editContext.text
checkTargetRanges(element, beforeInputTargetRanges, [1, 2], "Backspace");

await test_driver.send_keys(element, kDeleteKey);
assert_equals(textForView, "hello the");
assert_array_equals(textUpdateSelection, [9, 9]);
assert_equals(beforeInputType, "deleteContentForward");
assert_equals(beforeInputTargetRanges.length, 0, "Delete should not have a target range in EditContext");
checkTargetRanges(element, beforeInputTargetRanges, [2, 3], "Delete");

await new test_driver.Actions()
.keyDown(kModifierKey)
.keyDown(kBackspaceKey)
.keyUp(kBackspaceKey)
.keyUp(kModifierKey)
.send();
assert_equals(textForView.trim(), "hello");
assert_array_equals(textUpdateSelection, [6, 6]);
assert_equals(beforeInputType, "deleteWordBackward");
checkTargetRanges(element, beforeInputTargetRanges, [0, 2], "Ctrl+Backspace");

editContext.updateSelection(0, 0);
await new test_driver.Actions()
.keyDown(kModifierKey)
.keyDown(kDeleteKey)
.keyUp(kDeleteKey)
.keyUp(kModifierKey)
.send();
assert_equals(textForView.trim(), "");
assert_array_equals(textUpdateSelection, [0, 0]);
assert_equals(beforeInputType, "deleteWordForward");
checkTargetRanges(element, beforeInputTargetRanges, [2, 4], "Ctrl+Delete");

element.remove();
}

Expand Down Expand Up @@ -192,37 +235,45 @@
textForView = initialText;
element.focus();

if (element.tagName !== "CANVAS") {
// put selection in a text node which doesn't actually reflect editContext.text
let selectionTextNode = document.createTextNode("abcd");
element.append(selectionTextNode);
getSelection().setBaseAndExtent(selectionTextNode, 1, selectionTextNode, 3);
}

editContext.updateSelection(3, 6);
await test_driver.send_keys(element, kBackspaceKey);
assert_equals(editContext.text, "abcghijklmnopqrstuvwxyz");
assert_equals(textForView, "abcghijklmnopqrstuvwxyz");
assert_array_equals(textUpdateSelection, [3, 3]);
assert_equals(beforeInputType, "deleteContentBackward");
assert_equals(beforeInputTargetRanges.length, 0, "Backspace should not have a target range in EditContext");
// Target range should be based on DOM, not editContext.text
checkTargetRanges(element, beforeInputTargetRanges, [1, 3], "Backspace");

editContext.updateSelection(3, 6);
await test_driver.send_keys(element, kDeleteKey);
assert_equals(editContext.text, "abcjklmnopqrstuvwxyz");
assert_equals(textForView, "abcjklmnopqrstuvwxyz");
assert_array_equals(textUpdateSelection, [3, 3]);
assert_equals(beforeInputType, "deleteContentForward");
assert_equals(beforeInputTargetRanges.length, 0, "Delete should not have a target range in EditContext");
checkTargetRanges(element, beforeInputTargetRanges, [1, 3], "Delete");

editContext.updateSelection(6, 3);
await test_driver.send_keys(element, kBackspaceKey);
assert_equals(editContext.text, "abcmnopqrstuvwxyz");
assert_equals(textForView, "abcmnopqrstuvwxyz");
assert_array_equals(textUpdateSelection, [3, 3]);
assert_equals(beforeInputType, "deleteContentBackward");
assert_equals(beforeInputTargetRanges.length, 0, "Backspace should not have a target range in EditContext");
checkTargetRanges(element, beforeInputTargetRanges, [1, 3], "Backspace");

editContext.updateSelection(6, 3);
await test_driver.send_keys(element, kDeleteKey);
assert_equals(editContext.text, "abcpqrstuvwxyz");
assert_equals(textForView, "abcpqrstuvwxyz");
assert_array_equals(textUpdateSelection, [3, 3]);
assert_equals(beforeInputType, "deleteContentForward");
assert_equals(beforeInputTargetRanges.length, 0, "Delete should not have a target range in EditContext");
checkTargetRanges(element, beforeInputTargetRanges, [1, 3], "Delete");

element.remove();
}
Expand Down
Loading