Detect Simplified vs. Traditional Chinese in LanguageDetector API#60351
Draft
chromium-wpt-export-bot wants to merge 1 commit into
Draft
Detect Simplified vs. Traditional Chinese in LanguageDetector API#60351chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
Use the existing ChineseScriptClassifier used internally by the translation component to check whether text detected as Chinese is the Traditional or Simplified variant. To be efficiently called from Blink the Classify method is given a std::u16string_view variant. Fixed: 505173015 Bypass-Check-License: Moved files. Change-Id: If3060fad07837bc250c22fc315dcd7ee2c7d0e2f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the existing ChineseScriptClassifier used internally by the
translation component to check whether text detected as Chinese is the
Traditional or Simplified variant.
To be efficiently called from Blink the Classify method is given a
std::u16string_view variant.
Fixed: 505173015
Bypass-Check-License: Moved files.
Change-Id: If3060fad07837bc250c22fc315dcd7ee2c7d0e2f
Reviewed-on: https://chromium-review.googlesource.com/7797620
WPT-Export-Revision: 2fdd67c4ac744501bfa951c04dc380be6877a401