Change the order of non-intercepted events to match spec#60399
Open
chromium-wpt-export-bot wants to merge 1 commit into
Open
Change the order of non-intercepted events to match spec#60399chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
For non-intercepted navigations, the "navigatesuccess" event should fire before the promises resolve. This test fails because of the "WaitForAll" change and this fix should make it pass in Firefox as well. Bug: 519062396 Change-Id: Ie1e6bd1953b09148fbe68716935547f788421bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7902273 Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1641742}
wpt-pr-bot
approved these changes
Jun 4, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7902273
branch
from
b13ddea to
39eef50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For non-intercepted navigations, the "navigatesuccess" event
should fire before the promises resolve.
This test fails because of the "WaitForAll" change and this fix
should make it pass in Firefox as well.
Bug: 519062396
Change-Id: Ie1e6bd1953b09148fbe68716935547f788421bb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7902273
Commit-Queue: Noam Rosenthal <nrosenthal@google.com>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1641742}