Change ClipboardItem::getType() rejection to InvalidStateError#60406
Open
chromium-wpt-export-bot wants to merge 1 commit into
Open
Change ClipboardItem::getType() rejection to InvalidStateError#60406chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7902351
branch
from
09fa790 to
534470a
Compare
ClipboardItem.getType() should reject with InvalidStateError when the clipboard data has changed between read() and getType(), or when a null blob is returned from the clipboard reader. Chromium was using DataError at these rejection sites in clipboard_item.cc. This changes them to InvalidStateError for spec compliance. Bug: 519633341 Change-Id: Idd2458219b4d2b1b706b644e3f40ca84c1254057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7902351 Commit-Queue: Shweta Bindal <shwetabindal@microsoft.com> Reviewed-by: Rohan Raja <roraja@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1643732}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7902351
branch
from
534470a to
07363bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClipboardItem.getType() should reject with
InvalidStateError when the clipboard data has changed between read()
and getType(), or when a null blob is returned from the clipboard
reader. Chromium was using DataError at these rejection sites in
clipboard_item.cc. This changes them to InvalidStateError for spec
compliance.
Bug: 519633341
Change-Id: Idd2458219b4d2b1b706b644e3f40ca84c1254057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7902351
Commit-Queue: Shweta Bindal <shwetabindal@microsoft.com>
Reviewed-by: Rohan Raja <roraja@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1643732}