Remove incorrect getComputedStyle() test for ::first-line#60419
Merged
Conversation
Only a few properties apply to ::first-line, but that does not mean the computed value is affected. The test incorrectly assumed the computed value of vertical-align for ::first-line is reset to its initial value. Notified the author here: WebKit/WebKit#48454 (comment) Bug: 503879985 Change-Id: I1f37b490a0d4eef452c89242d0e962a7b834e6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7900679 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1642181}
wpt-pr-bot
approved these changes
Jun 5, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only a few properties apply to ::first-line, but that does not mean the
computed value is affected. The test incorrectly assumed the computed
value of vertical-align for ::first-line is reset to its initial value.
Notified the author here:
WebKit/WebKit#48454 (comment)
Bug: 503879985
Change-Id: I1f37b490a0d4eef452c89242d0e962a7b834e6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7900679
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1642181}