ContainerTiming: tests for pre-paint attribution tracker#61423
Draft
chromium-wpt-export-bot wants to merge 1 commit into
Draft
ContainerTiming: tests for pre-paint attribution tracker#61423chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
Split out of the pre-paint attribution tracker implementation CL to keep that change focused on production code. Adds: - Unit tests for the ContainerTimingPaintAttributionTracker and for ContainerTiming aggregation/caching under both flag states. - pre_paint_tree_walk_test.cc coverage for the container-timing dirty-bit propagation and the ShouldInheritContainerTimingRoot cache. - display_lock_context_test.cc coverage for the container-timing interaction with display locking. - container_timing_test_utils.h, shared by blink_unittests and blink_perf_tests via unit_test_support. - WPTs for container timing roots with containertiming-ignore reporting their own paints, plus a virtual test suite running the existing container-timing WPTs with ContainerTimingPrepaintTraversal enabled. All Container Timing Web Platform Tests pass with both the legacy implementation and the prepaint optimization. Bug: 489959278 Change-Id: Iaad076cafb821c7807edb739db764b34072ed0bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of the pre-paint attribution tracker implementation CL to keep
that change focused on production code.
Adds:
ContainerTiming aggregation/caching under both flag states.
propagation and the ShouldInheritContainerTimingRoot cache.
interaction with display locking.
blink_perf_tests via unit_test_support.
their own paints, plus a virtual test suite running the existing
container-timing WPTs with ContainerTimingPrepaintTraversal enabled.
All Container Timing Web Platform Tests pass with both the legacy
implementation and the prepaint optimization.
Bug: 489959278
Change-Id: Iaad076cafb821c7807edb739db764b34072ed0bc
Reviewed-on: https://chromium-review.googlesource.com/7979158
WPT-Export-Revision: e580d5e3827e762b5a35d9e6aca43a39c4861dff