[css-mixins] Test that @layer is dropped inside mixins#61427
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
July 20, 2026 19:04
Blink already drops @layer inside mixins per the CSSWG resolution [0], but existing tests only checked the mixin stayed valid, not that @layer was dropped. Add test cases asserting @layer is dropped at every depth inside a mixin, each keeping a sibling "color: green" rule to confirm only the @layer, not its container, was removed. [0] w3c/csswg-drafts#12417 Bug: 440050694 Change-Id: I08c354d23e25f33ba0b843292bb931009570319d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8114962 Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1664819}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8114962
branch
from
July 20, 2026 19:04
ca64e77 to
f609e25
Compare
wpt-pr-bot
approved these changes
Jul 20, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blink already drops @layer inside mixins per the CSSWG resolution [0],
but existing tests only checked the mixin stayed valid, not that @layer
was dropped.
Add test cases asserting @layer is dropped at every depth inside a
mixin, each keeping a sibling "color: green" rule to confirm only the
@layer, not its container, was removed.
[0] w3c/csswg-drafts#12417
Bug: 440050694
Change-Id: I08c354d23e25f33ba0b843292bb931009570319d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8114962
Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1664819}