[WebTransport] Correctly test use of WebTransportOptions.datagramsReadableType#61428
Open
achristensen07 wants to merge 1 commit into
Open
Conversation
…dableType https://www.w3.org/TR/webtransport/#dom-webtransportoptions-datagramsreadabletype says to use a readable byte stream if datagramsReadableType is specified, but to use a readable stream otherwise. https://streams.spec.whatwg.org/#readable-byte-stream says the former is needed to use byob buffers. This change is from WebKit/WebKit#69795
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/TR/webtransport/#dom-webtransportoptions-datagramsreadabletype says to use a readable byte stream if datagramsReadableType is specified, but to use a readable stream otherwise. https://streams.spec.whatwg.org/#readable-byte-stream says the former is needed to use byob buffers.
This change is from WebKit/WebKit#69795