Skip to content

[WebTransport] Correctly test use of WebTransportOptions.datagramsReadableType #61428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achristensen07 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WebTransport] Correctly test use of WebTransportOptions.datagramsReadableType #61428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions webtransport/datagrams.https.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ promise_test(async t => {

promise_test(async t => {
// Establish a WebTransport session.
const wt = new WebTransport(webtransport_url('echo.py'));
const wt = new WebTransport(webtransport_url('echo.py'), { 'datagramsReadableType' : 'bytes' });
await wt.ready;

const writer = wt.datagrams.createWritable().getWriter();
Expand All @@ -145,9 +145,15 @@ promise_test(async t => {
}, 'Successfully reading datagrams with BYOB reader.');

promise_test(async t => {
// Establish a WebTransport session.
const wt = new WebTransport(webtransport_url('echo.py'));
await wt.ready;
assert_throws_js(TypeError, () => { wt.datagrams.readable.getReader({ mode: 'byob' }) });
}, 'Reading datagrams with BYOB reader without datagramsReadableType should fail.');

promise_test(async t => {
// Establish a WebTransport session.
const wt = new WebTransport(webtransport_url('echo.py'), { 'datagramsReadableType' : 'bytes' });
await wt.ready;

const writer = wt.datagrams.createWritable().getWriter();
const reader = wt.datagrams.readable.getReader({ mode: 'byob' });
Expand Down
Loading