[WebXR] Detect all frame owners in DOM Overlay#61430
Merged
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
July 21, 2026 05:31
ProcessOverlayHitTest downcasts the hit element to HTMLFrameElementBase to decide whether to walk the content frame subtree for cross-origin content. That base class only covers <iframe> and <frame>; content embedded via <object>, <embed>, or <fencedframe> owns a content frame through HTMLFrameOwnerElement instead, so the cast returned null and the cross-origin check was skipped. Cast to HTMLFrameOwnerElement instead so every frame-owning element is subject to the same origin check. Extend the ar_dom_overlay WPT with an <object> variant of the existing cross-origin iframe test. TAG=agy Fixed: 524418836 Change-Id: I43830c7a669820dbb56c3a1792d9f7c6813d1c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8120459 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#1665189}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8120459
branch
from
July 21, 2026 05:31
8e44c04 to
36bd9a7
Compare
wpt-pr-bot
approved these changes
Jul 21, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessOverlayHitTest downcasts the hit element to HTMLFrameElementBase
to decide whether to walk the content frame subtree for cross-origin
content. That base class only covers <iframe> and <frame>; content
embedded via <object>, <embed>, or <fencedframe> owns a content frame
through HTMLFrameOwnerElement instead, so the cast returned null and
the cross-origin check was skipped.
Cast to HTMLFrameOwnerElement instead so every frame-owning element is
subject to the same origin check. Extend the ar_dom_overlay WPT with
an <object> variant of the existing cross-origin iframe test.
TAG=agy
Fixed: 524418836
Change-Id: I43830c7a669820dbb56c3a1792d9f7c6813d1c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8120459
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1665189}