[css-mixins] Make @apply and @contents rules StyleRuleGroups#61433
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
July 21, 2026 16:18
@apply and @contents carry child rules but extended StyleRuleBase, stashing them on a throwaway "fake parent" StyleRule. This CL makes them extend StyleRuleGroup, owning their children directly and joining DowncastTraits<StyleRuleGroup> and continuing the work from CL:7755161. This is a behavior-preserving refactor. A web test was added confirming that an empty `@apply --foo {}` block suppresses the mixin's @contents fallback, while `@apply --foo;` still lets it apply. Change-Id: I033b0d0b0e6d399152cb6ce3e1ac4dfd0c563c48 Fixed: 502048295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8114919 Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1665525}
wpt-pr-bot
approved these changes
Jul 21, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8114919
branch
from
July 21, 2026 16:18
727f969 to
7430d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@apply and @contents carry child rules but extended StyleRuleBase,
stashing them on a throwaway "fake parent" StyleRule. This CL makes them
extend StyleRuleGroup, owning their children directly and joining
DowncastTraits<StyleRuleGroup> and continuing the work from CL:7755161.
This is a behavior-preserving refactor. A web test was added confirming
that an empty
@apply --foo {}block suppresses the mixin's @contentsfallback, while
@apply --foo;still lets it apply.Change-Id: I033b0d0b0e6d399152cb6ce3e1ac4dfd0c563c48
Fixed: 502048295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8114919
Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1665525}