Update rules for Remastered, Version, Clean/Explicit filters#394
Open
hornbuckle wants to merge 14 commits into
Open
Update rules for Remastered, Version, Clean/Explicit filters#394hornbuckle wants to merge 14 commits into
hornbuckle wants to merge 14 commits into
Conversation
Remove redundant "Explicit Version"
Remove redundant "Explicit Version"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you made
Additional context
Initially, I was just going to update the first Remastered rule for this and similar cases, as the existing version was too limited and only applied when "Live" was included. Then I noticed a few others that could be updated/added, including case insensitivity. Not all sites will necessarily capitalize this text when included in the title.
The rule for From "Movie Title" was added to the Version filter because that seemed to be the most appropriate spot for it—part of a collection of additional information that shouldn't be included with the title—and it didn't seem like it required a separate filter of its own.
Lastly, it seems debatable that Clean/Explicit even needs its own filter, as it could be integrated into Version. But since it is currently its own filter, it is redundant to have "Explicit Version" (but no "Clean Version") in the Version rules.