Merge pull request #948 from web3dev1337/fix/nsis-kill-node-before-install

fix: kill orphaned node.exe before NSIS install to prevent file lock error

Author: web3dev1337

ai-memory/fix/nsis-kill-node-before-install-d3e6aed/init.md

@@ -0,0 +1,10 @@
+# Fix: NSIS installer "Error opening file for writing" on node.exe
+
+## Problem
+Windows NSIS installer fails with "Error opening file for writing: C:\Users\AB\AppData\Local\agent-workspace\resources\backend\node\node.exe" when reinstalling after uninstall.
+
+## Root Cause
+The bundled node.exe (backend server) is still running as an orphaned process after app close/uninstall, holding a file lock. The installer can't overwrite a locked file.
+
+## Solution
+Add NSIS preinstall hook that kills node.exe and Agent Workspace.exe before file extraction.

ai-memory/fix/nsis-kill-node-before-install-d3e6aed/progress.md

@@ -0,0 +1,6 @@
+- [x] Investigate root cause (orphaned node.exe holding file lock)
+- [x] Research Tauri v2 NSIS hook API
+- [x] Create src-tauri/windows/hooks.nsh with PREINSTALL + PREUNINSTALL hooks
+- [x] Add installerHooks config to tauri.conf.json
+- [ ] Commit and push
+- [ ] Create PR

src-tauri/tauri.conf.json

@@ -45,6 +45,11 @@
     "macOS": {
       "bundleName": "Agent Workspace"
     },
+    "windows": {
+      "nsis": {
+        "installerHooks": "./windows/hooks.nsh"
+      }
+    },
     "resources": [
       "resources/backend/*",
       "resources/backend/config/**/*",

src-tauri/windows/hooks.nsh

@@ -0,0 +1,22 @@
+; Agent Workspace NSIS installer hooks
+; Kills ONLY the node.exe spawned by Agent Workspace (path-filtered),
+; not the user's other Node.js processes.
+
+!macro NSIS_HOOK_PREINSTALL
+  ; Kill any running Agent Workspace instance (safe — it's our app)
+  nsExec::ExecToLog 'taskkill /IM "Agent Workspace.exe" /F'
+
+  ; Kill ONLY node.exe running from the agent-workspace install directory.
+  ; Uses PowerShell path filter so we never touch the user's other Node processes.
+  ; -ErrorAction SilentlyContinue: no error if nothing to kill.
+  nsExec::ExecToLog "powershell -NoProfile -Command $\"Get-Process -Name node -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like '*agent-workspace*' } | Stop-Process -Force -ErrorAction SilentlyContinue$\""
+
+  ; Let Windows release file handles
+  Sleep 1000
+!macroend
+
+!macro NSIS_HOOK_PREUNINSTALL
+  nsExec::ExecToLog 'taskkill /IM "Agent Workspace.exe" /F'
+  nsExec::ExecToLog "powershell -NoProfile -Command $\"Get-Process -Name node -ErrorAction SilentlyContinue | Where-Object { $$_.Path -like '*agent-workspace*' } | Stop-Process -Force -ErrorAction SilentlyContinue$\""
+  Sleep 1000
+!macroend