Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: tests

on:
pull_request:
push:
branches:
- main

jobs:
unit:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: "20"
cache: "npm"

- name: Install
run: npm ci

- name: Unit tests
run: npm run test:unit

16 changes: 8 additions & 8 deletions GAP_ANALYSIS_2026-01-17.md
Original file line number Diff line number Diff line change
Expand Up @@ -267,20 +267,20 @@ Week 10: Phase 4 + Final polish
## Quick Wins (Can Do Today)

1. [ ] **Revoke API key** (5 min) - CRITICAL
2. [ ] **Add .env to .gitignore** (1 min)
3. [ ] **Create .env.example** (5 min)
2. [x] **Add .env to .gitignore** (1 min)
3. [x] **Create .env.example** (5 min)
4. [ ] **Fix `/home/ab` fallback** in gitHelper.js (5 min)
5. [ ] **Fix `/tmp/` path** in index.js (5 min)
6. [ ] **Create CI workflow file** (30 min)
6. [x] **Create CI workflow file** (30 min)

---

## Files to Modify

### Security Fixes
- [ ] `.env` - Remove from repo
- [ ] `.gitignore` - Add `.env`
- [ ] `.env.example` - Create with placeholders
- [x] `.env` - Remove from repo
- [x] `.gitignore` - Add `.env`
- [x] `.env.example` - Create with placeholders

### Hardcoded Paths
- [ ] `server/workspaceManager.js` - Lines 464, 488
Expand All @@ -301,7 +301,7 @@ Week 10: Phase 4 + Final polish
- [ ] `tests/unit/agentManager.test.js`
- [ ] `tests/integration/socketio-events.test.js`
- [ ] `tests/integration/api-endpoints.test.js`
- [ ] `.github/workflows/test.yml`
- [x] `.github/workflows/tests.yml`

---

Expand All @@ -310,7 +310,7 @@ Week 10: Phase 4 + Final polish
### MVP (Deployable)
- [ ] No exposed secrets
- [ ] No hardcoded user-specific paths
- [ ] CI/CD running tests on PRs
- [x] CI/CD running tests on PRs
- [ ] 60%+ test coverage on critical paths
- [ ] Installation works on fresh machine

Expand Down
Loading