fix(windows): make node-pty compat shape-based#980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conpty.nodepatching whennode-pty/lib/utils.loadNativeModuleis unavailableRoot cause
Recent Windows PTY fixes landed in this sequence:
windowsPtyAgent.jsserver/utils/nodePtyCompat.jsThe regression is that the current shim assumes two things that are not consistently true across installs:
node-pty/package.jsonreports1.2.0-beta.12node-pty/lib/utilsexposesloadNativeModuleIn this checkout, the installed module reports
1.0.0andlib/utils.jsdoes not exposeloadNativeModule, so the current runtime shim can skip entirely even on Windows installs that still need compatibility patching. That explains why behavior can diverge across machines and upgrades.Notes
loadNativeModulewhen available, but no longer depends on it.Test plan
1.0.0, demonstrating why exact-version gating is brittle