feat(orion-scheduler): migrate into mega workspace with configurable …#2099
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f084993a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6369ace716
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
benjamin-747
force-pushed
the
main
branch
4 times, most recently
from
2ee5016 to
2d9a25c
Compare
…paths - Add orion-scheduler as a Cargo workspace member - Move hardcoded paths (orion_source_dir, orion_binary_path, ssh_public_key_path) to target_config.json - Add target_config.json.template as a configuration reference - Remove custom_images/default_image config in favor of API-driven image parameters - Add build-custom-image.sh with configurable OUTPUT_DIR via env var - Update documentation (README, DESIGN, TESTING, ARTIFACT)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95dca755d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,22 @@ | |||
| [workspace] | |||
There was a problem hiding this comment.
This manifest declares a nested [workspace], and the root /workspace/mega/Cargo.toml does not list orion-scheduler; I checked root cargo metadata and orion-scheduler is absent from workspace_members. In contexts where CI or developers run cargo check --workspace from /workspace/mega, the new service is skipped entirely, so build/test regressions can merge unnoticed. Remove the nested workspace and add the package to the root workspace members (or otherwise wire it into the root checks).
Useful? React with 👍 / 👎.
| "log_dir": "/var/log/orion-scheduler", | ||
| "orion_source_dir": "/path/to/mega/orion", | ||
| "orion_binary_path": "/path/to/mega/target/debug/orion", | ||
| "ssh_public_key_path": "~/.ssh/orion_vm_access.pub", |
There was a problem hiding this comment.
The template uses ~/.ssh/..., but inject_ssh_keys passes ssh_public_key_path directly to Path::new and then checks exists(), so Rust will look for a literal ~ directory rather than the user's home directory. Users copying this config will silently skip SSH key injection and lose the documented VM debug access; either expand ~ when loading the config or use an absolute path in the template.
Useful? React with 👍 / 👎.
717d760
2 participants
…paths