fix(release): support Windows and Linux prereleases#756
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release workflow adds ChangesRelease Scope Publishing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ReleaseEvent
participant prepare-release
participant PlatformBuilds
participant publish-release-assets
participant HomebrewTap
ReleaseEvent->>prepare-release: resolve and validate release_scope
prepare-release->>PlatformBuilds: pass release_scope output
PlatformBuilds->>publish-release-assets: provide successful scoped artifacts
publish-release-assets->>HomebrewTap: trigger only for full non-prerelease releases
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 54-68: Replace the inline GitHub expression expansions for tag
names in the release workflow’s shell block with environment-variable inputs,
and read those variables inside the release and workflow_dispatch branches
before assigning TAG_NAME. Ensure shell interpolation cannot execute tag
contents, while preserving the existing marker detection, release-scope
fallback, and subsequent validation behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b5c4849-a823-4703-9fee-cc9da45bd56b
📒 Files selected for processing (1)
.github/workflows/release.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit
windows-linuxscope for prereleases while keeping stable and ordinary release runs fail-closed on every platform.Problem and root cause
The reviewed
v1.3.5-beta.2source builds on Windows and Linux, but both signed macOS jobs are blocked by invalid Apple notarization credentials. The existing workflow requires all four platforms, so its publish job correctly skips every release asset.Focused change
all/windows-linuxon manual release dispatch<!-- release-scope: windows-linux -->only on prerelease publicationThe default remains
all; no product source, version, tag, dependency, or signing policy changes.Verification
actionlint1.7.12npx tsc --noEmitnpm run lint(pass; inherited warnings)npm test— 106 files, 995 pass, 1 skipgit diff --checkRisk and rollback
Risk is limited to release orchestration. The partial path is prerelease-only and opt-in; removing the merge commit restores the all-platform gate.
v1.3.5-beta.2will be labeled Windows/Linux only, with macOS unavailable and the Windows installer disclosed as unsigned.Summary by CodeRabbit