Merge branch 'dev'

Author: kalwalt

.claude/issue-86-design.md

@@ -27,6 +27,9 @@ jobs:
     - name: Run cargo fmt check
       run: cargo fmt --all -- --check
 
+    - name: Run cargo clippy
+      run: cargo clippy --workspace -- -D warnings
+
     - name: Run cargo check
       run: cargo check --workspace
     - name: Run cargo test
@@ -112,7 +115,7 @@ jobs:
 
     - name: Run native simple example
       working-directory: crates/core
-      run: cargo run --example simple
+      run: cargo run --example simple --features log-helpers
 
   benchmarks:
     runs-on: ubuntu-latest
@@ -123,7 +126,7 @@ jobs:
 
     - name: Generate hiro.raw for C benchmark
       working-directory: crates/core
-      run: cargo run --example simple -- ../../benchmarks/data/camera_para.dat ../../benchmarks/data/patt.hiro ../../benchmarks/data/img.jpg
+      run: cargo run --example simple --features log-helpers -- ../../benchmarks/data/camera_para.dat ../../benchmarks/data/patt.hiro ../../benchmarks/data/img.jpg
 
     - name: Run benchmarks
       run: |

.github/workflows/ci.yml

@@ -34,3 +34,4 @@ crates/wasm/pkg/
 !crates/wasm/pkg/LICENSE
 !crates/wasm/pkg/README.md
 !crates/wasm/pkg/package.json
+.DS_Store

.gitignore

@@ -2,6 +2,61 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.3.8] - 2026-05-04
+
+### Last action before  `Milestone 6 — Math & homography in pure Rust`
+
+### ⚙️ Miscellaneous Tasks
+
+- Pass --features log-helpers when running simple example
+- Remove accidental .DS_Store from repo changes
+- Convert println!/eprintln! to arlog_*! in examples and bench
+
+### 🎨 Styling
+
+- Apply cargo fmt --all (fixes CI fmt check)
+- *(core)* Fix formatting issues
+- *(marker)* Apply cargo fmt
+- *(diagnostic)* Apply stable rustfmt wrapping (#104 CI)
+
+### 🐛 Bug Fixes
+
+- *(clippy)* Clear all warnings and add clippy -D warnings to CI
+- *(clippy)* Fix 5 CI-only clippy warnings (explicit_counter_loop, manual_checked_ops)
+- *(marker)* Populate cf_patt/id_patt and copy to final id/cf per mode
+- *(core)* Port confidence_cutoff from C and add regression tests (issue #92)
+- *(marker)* Wire cutoff_phase from MatchOk/MatchError result codes (#88)
+- *(marker)* Resolve merge conflict in cutoff_phase tests
+- *(simple,marker)* Honour the buff/pixel_format contract (#103)
+
+### 📚 Documentation
+
+- *(issue-86)* Add implementation plan
+- Update CLAUDE.md with documentation and style guidelines
+- *(issue-103)* Correct findings — Rust/C cf close but not byte-equal
+
+### 🚀 Features
+
+- *(marker)* Add finalize_marker_id_cf_dir helper
+- *(types)* Add MatchOk, MatchError, From<MatchError> for ARMarkerInfoCutoffPhase
+- *(core)* Add ar_detect_marker orchestrator for full marker detection pipeline
+- *(types)* Add AR tracking history mode constants (#101)
+- *(marker)* Port arDetectMarker tracking history pipeline (#96)
+- *(diagnostic)* Add dump_patt + diff_patt for issue #103
+
+### 🚜 Refactor
+
+- *(core)* Move AR modules into ar/ subfolder (closes #82)
+- *(types)* Defer MatchOk.global_id field to issue #89
+- *(pattern)* Pattern_match returns Result<MatchOk, MatchError>
+- *(matrix)* Ar_matrix_code_get_id returns Result<MatchOk, MatchError>
+
+### 🧪 Testing
+
+- *(marker)* Add failing tests for finalize_marker_id_cf_dir helper
+- *(marker)* Add confidence_cutoff edge case and mode-specific unit tests (#96)
+- *(marker)* Extract history phases as helpers and add 12 unit tests (#96)
+
 ## [0.3.7] - 2026-04-23
 
 ### 🐛 Bug Fixes

CHANGELOG.md

@@ -158,3 +158,30 @@ Stage 3 in `crates/core/src/ar2/feature_map.rs`.
 - [ ] No `println!` / `eprintln!` added in library code
 - [ ] CHANGELOG.md **not** touched
 - [ ] Branch is off current `dev`
+
+## 📝 Documentation & Style
+- All comments, docstrings, and commit messages must be in **English**.
+- Use `Result<T, PureCvError>` for error handling instead of `panic!`.
+- Create tests for every functions / type and benchmarks if possible.
+- Add HEADER.txt to every new file you create. You found it in `.claude\HEADER.txt`.
+
+> **CI will reject any PR that fails `cargo fmt -- --check` or `cargo clippy`.**
+
+## 🐙 Github Instructions & Conventional Commits
+- When creating a PR always start from the `dev` branch and point against `dev` branch.
+- **MANDATORY:** You must use the [Conventional Commits](https://www.conventionalcommits.org/) specification for all commit messages. This is strictly required for our automated `git-cliff` changelog generation.
+- **Format:** `<type>(<optional scope>): <description>`
+- **Allowed Types:**
+  - `feat`: A new feature or algorithm implementation.
+  - `fix`: A bug fix.
+  - `perf`: A code change that improves performance (e.g., optimizations).
+  - `doc`: Documentation only changes.
+  - `refactor`: A code change that neither fixes a bug nor adds a feature.
+  - `test`: Adding missing tests or correcting existing ones.
+  - `chore`: Changes to the build process, dependencies, or auxiliary tools.
+- **Preferred Scopes for PureCV:** Use scopes to categorize the architectural work, such as `(simd)`, `(wasm)`, `(parallel)`, `(core)`, `(imgproc)`.
+- **Examples of valid commits:**
+  - `feat(simd): implement AVX2 support for matrix multiplication`
+  - `perf(wasm): optimize memory allocation for Emscripten target`
+  - `fix(core): resolve out-of-bounds error in Row-Major layout`
+  - `doc: add usage examples for parallel processing`

CLAUDE.md

@@ -9,7 +9,7 @@ exclude = [
 resolver = "2"
 
 [workspace.package]
-version = "0.3.7"
+version = "0.3.8"
 authors = ["kalwalt <github@kalwaltart.it>"]
 edition = "2021"
 description = "A high-performance, memory-safe Rust port of WebARKitLib (ARToolKit) for native and WASM."

Cargo.toml

@@ -187,6 +187,18 @@ elseif(NOT WIN32)
     target_link_libraries(c_benchmark m)
 endif()
 
+# ── Pattern-extraction diagnostic dumper (issue #103) ──
+# Sibling of c_benchmark; runs detection once, re-extracts the matched patch
+# via arPattGetImage, and dumps it for byte-comparison with the Rust port.
+# See ../data/README.md and ../../docs/issue-103-fix-plan.md.
+add_executable(dump_patt ${AR_CORE_SOURCES} "dump_patt.c")
+target_compile_definitions(dump_patt PRIVATE ${COMMON_DEFS})
+if(WIN32 AND MSVC)
+    target_compile_options(dump_patt PRIVATE /W3 /Z7)
+elseif(NOT WIN32)
+    target_link_libraries(dump_patt m)
+endif()
+
 # ── KPM targets (fixture generator + benchmark) ──
 # These require libjpeg-9f (bootstrapped) and are NOT built by default.
 # Build manually with: cmake --build . --target kpm_dump_fixtures