ci(benchmarks): harden against flaky external C-library downloads (#204)#213
Merged
Conversation
The benchmarks job built a C baseline by downloading external sources (jpeg-9f from ijg.org, WebARKitLib) at CI time; a TLS/network flake there (and a missing `svn`) failed the whole gate even though the Rust code was fine (#204). - Install `subversion` (the bootstrap warned `svn not found`). - Cache the downloaded C sources keyed on libraries.json hash. - Run the C baseline as a NON-BLOCKING step (`continue-on-error`) with a 3x retry on the flaky bootstrap download — it only yields an optional comparison log. - Keep `cargo bench` (marker_bench) as the required gate signal. Now a transient external-download failure degrades gracefully instead of failing the benchmarks gate. Closes #204. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kalwalt
added this to the
v0.8.0 — Pure-Rust completeness, validation & polish milestone
github-project-automation
Bot
moved this from In progress
to Done
in Plan to port KPM to rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
benchmarksCI job built a C baseline by downloading external sources at run time (jpeg-9f fromijg.org, WebARKitLib). A TLS/network flake there — plus a missingsvn— failed the whole gate even though the Rust code was fine (#204; originally hit on PR #199).Closes #204.
Changes (
.github/workflows/ci.yml,benchmarksjob)subversion— the bootstrap loggedcommand svn not found.benchmarks/c_benchmark/archives) keyed onlibraries.jsonhash — fewer live downloads.continue-on-error: true) with a 3x retry on the flakybootstrap.pydownload. It only produces an optional comparison log.cargo bench --bench marker_benchas the required gate — the actual signal.Net effect: a transient external-download failure now degrades gracefully (skips the C comparison) instead of failing the benchmarks gate. The Rust benchmarks still run and gate as before.
Note
This workflow change is exercised by this PR's own CI run, which validates the new job end-to-end.
🤖 Generated with Claude Code