feat(kpm): facade-parity accessors on VisualDatabase + FeatureStore slices (#148)#216
Merged
Conversation
…atureStore slices (#148) Mirror `VisualDatabaseFacade`'s Group-A accessors so the Rust port is a drop-in for the C++ facade surface, and callers don't have to loop `0..num_features()` element-by-element. Pure additive getters — no behavior change. - `FeatureStore`: add slice accessors `points() -> &[FeaturePoint]` and `descriptors() -> &[u8]` (counterparts to per-element `point(i)`/`descriptor(i)`). - `VisualDatabase`: add `get_feature_points(id)`, `get_descriptors(id)`, `get_query_feature_points()`, `get_query_descriptors()`, `get_width(id)`, `get_height(id)` (Option-returning, 1-liners over the slice accessors). - Tests for both (deterministic, no image pipeline). Group B (3D feature points — RustFreakMatcher/NFT domain) and Group C (computeFreakFeaturesAndDescriptors — no caller) are out of scope. Refs #148. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kalwalt
added
enhancement
github-project-automation
Bot
moved this from In review
to Done
in Plan to port KPM to rust
Closed
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
VisualDatabaseFacadeGroup-A convenience accessors to the Rust port so it's a drop-in for the C++ facade surface, plus theFeatureStoreslice accessors they build on. Pure additive getters — no behavior change, no algorithmic risk.Closes #148. (v0.8.0 milestone close-out, 1/4.)
Changes
FeatureStore(matcher.rs):points() -> &[FeaturePoint],descriptors() -> &[u8]— slice counterparts to the per-elementpoint(i)/descriptor(i), so callers stop iterating0..num_features().VisualDatabase(visual_database.rs):get_feature_points(id),get_descriptors(id),get_query_feature_points(),get_query_descriptors(),get_width(id),get_height(id)—Option-returning 1-liners over the slice accessors (idiomatic vs the C++ raw returns).Out of scope (per #148)
get3DFeaturePoints— NFT 3D state, lives onRustFreakMatcher).computeFreakFeaturesAndDescriptors— no current caller).Verification
cargo clippy --all-targets --all-features -- -D warningscleancargo test --all-featuresgreen (2 new tests)🤖 Generated with Claude Code