Merge pull request #209 from esokullu/agent/planner-provider-retry

Add recovery actions for planner provider failures

Author: webbrain-one

src/chrome/src/agent/agent.js

@@ -126,6 +126,19 @@ function isBrowserNewTabUrl(url) {
   return BROWSER_NEW_TAB_URL_PREFIXES.some(prefix => value.startsWith(prefix));
 }
 
+function plannerRequestFailureKind(detail) {
+  const text = String(detail || '');
+  const statusMatch = text.match(/\b(?:error|http|status)\s*[:#-]?\s*(\d{3})\b/i)
+    || text.match(/\b(401|403|408|425|429|5\d\d)\b/);
+  const status = Number(statusMatch?.[1] || 0);
+  if (status === 401 || status === 403) return 'auth';
+  if ([408, 425, 429].includes(status) || status >= 500) return 'transient';
+  if (/\b(?:timed?\s*out|timeout|network|fetch failed|connection (?:closed|reset|refused)|econn\w+|temporar(?:y|ily)|unavailable)\b/i.test(text)) {
+    return 'transient';
+  }
+  return 'provider';
+}
+
 /**
  * The WebBrain Agent — orchestrates multi-step LLM + tool-use loops.
  */
@@ -7362,20 +7375,31 @@ Rules: no prose intro, no conclusion, no "this screenshot shows...", no layout d
     };
   }
 
-  _plannerRequestFailure(error, onUpdate) {
+  _plannerRequestFailure(error, onUpdate, provider = null) {
     const detail = sanitizePlannerText(
       error?.message || String(error || 'Unknown planner request error.'),
       500,
       { collapseWhitespace: true },
     );
-    const message = `Planner request failed before a valid response was available: ${detail}`;
-    onUpdate('warning', { message });
+    const message = `Planner request failed before a valid response was available: ${detail} No tools ran.`;
+    const failureKind = plannerRequestFailureKind(detail);
+    onUpdate('warning', {
+      code: 'planner_request_failed',
+      message,
+      failureKind,
+      provider: sanitizePlannerText(
+        provider?.config?.label || provider?.name || provider?.config?.providerName || '',
+        80,
+        { collapseWhitespace: true },
+      ),
+    });
     return {
       proceed: false,
       message,
       reason: 'planner_error',
       requestKind: 'respond',
       requiresStateChange: false,
+      failureKind,
     };
   }
 
@@ -7564,7 +7588,7 @@ Rules: no prose intro, no conclusion, no "this screenshot shows...", no layout d
       if (this._isCostAllowanceError(e)) {
         return { proceed: false, message: e.message, reason: 'cost_limit' };
       }
-      return this._plannerRequestFailure(e, onUpdate);
+      return this._plannerRequestFailure(e, onUpdate, provider);
     }
   }
 
@@ -7786,7 +7810,7 @@ Rules: no prose intro, no conclusion, no "this screenshot shows...", no layout d
       if (this._isCostAllowanceError(e)) {
         return { proceed: false, message: e.message, reason: 'cost_limit' };
       }
-      return this._plannerRequestFailure(e, onUpdate);
+      return this._plannerRequestFailure(e, onUpdate, provider);
     }
   }
 

src/chrome/src/background.js

@@ -1380,16 +1380,25 @@ function isClarificationRequiredRunUpdate(update) {
     && update?.data?.status === 'clarification_required';
 }
 
+function isPlannerRequestFailureUpdate(update) {
+  return update?.type === 'warning'
+    && update?.data?.code === 'planner_request_failed';
+}
+
 function runUpdatesSucceeded(updates = []) {
-  return !updates.some(update => update?.type === 'error' || isClarificationRequiredRunUpdate(update));
+  return !updates.some(update => (
+    update?.type === 'error'
+    || isClarificationRequiredRunUpdate(update)
+    || isPlannerRequestFailureUpdate(update)
+  ));
 }
 
 function terminalRunUiStatus(content, updates = [], error = null) {
   if (error) return 'failed';
   const text = String(content || '');
   if (/stopped by user|aborted by user/i.test(text)) return 'stopped';
   if (/before executing requested tool calls/i.test(text)) return 'cancelled';
-  if (updates.some(update => update?.type === 'error')) return 'failed';
+  if (updates.some(update => update?.type === 'error' || isPlannerRequestFailureUpdate(update))) return 'failed';
   if (updates.some(isClarificationRequiredRunUpdate)) return 'clarification_required';
   return 'completed';
 }

src/chrome/src/ui/sidepanel.js

@@ -1703,10 +1703,10 @@ function releaseRetryAttachmentPayload(retryId) {
 
 function releaseRetryAttachmentsInTree(root) {
   if (!root) return;
-  if (root.matches?.('.error-retry-btn[data-retry-id], .cost-allowance-retry-btn[data-retry-id]')) {
+  if (root.matches?.('.error-retry-btn[data-retry-id], .cost-allowance-retry-btn[data-retry-id], .planner-request-failure-retry-btn[data-retry-id]')) {
     releaseRetryAttachmentPayload(root.dataset.retryId);
   }
-  root.querySelectorAll?.('.error-retry-btn[data-retry-id], .cost-allowance-retry-btn[data-retry-id]').forEach((btn) => {
+  root.querySelectorAll?.('.error-retry-btn[data-retry-id], .cost-allowance-retry-btn[data-retry-id], .planner-request-failure-retry-btn[data-retry-id]').forEach((btn) => {
     releaseRetryAttachmentPayload(btn.dataset.retryId);
   });
 }
@@ -3738,6 +3738,15 @@ async function adoptRestoredRunState(tabId, state) {
       probeFirst: true,
       requireDurableSubmittedTurn: runUi.kind !== 'continue',
     });
+    const returnedPlannerFailure = plannerRequestFailureUpdate(res?.updates);
+    if (returnedPlannerFailure && sameTabId(currentTabId, tabId) && !isTabAbortRequested(tabId)) {
+      const targetAssistantEl = assistantEl || currentAssistantEl;
+      renderPlannerRequestFailure(
+        targetAssistantEl,
+        returnedPlannerFailure.data,
+        retryPayloadForRunAssistant(targetAssistantEl),
+      );
+    }
     const returnedErrorUpdate = Array.isArray(res?.updates)
       ? res.updates.find(update => update?.type === 'error')
       : null;
@@ -5165,7 +5174,7 @@ function bindErrorRetryButton(btn) {
 }
 
 function rebindRetryButtons() {
-  document.querySelectorAll('.error-retry-btn').forEach(bindErrorRetryButton);
+  document.querySelectorAll('.error-retry-btn, .planner-request-failure-retry-btn').forEach(bindErrorRetryButton);
 }
 
 function createActiveChatPayloadState(retryPayload, requestId = '') {
@@ -5204,6 +5213,81 @@ function retryPayloadForRunAssistant(assistantEl) {
   };
 }
 
+function plannerRequestFailureUpdate(updates = []) {
+  if (!Array.isArray(updates)) return null;
+  return updates.find(update => (
+    update?.type === 'warning'
+    && update?.data?.code === 'planner_request_failed'
+  )) || null;
+}
+
+function bindPlannerProviderSettingsButton(btn) {
+  if (!btn || btn.dataset.bound) return;
+  btn.dataset.bound = 'true';
+  btn.addEventListener('click', async (event) => {
+    event.preventDefault();
+    event.stopPropagation();
+    btn.disabled = true;
+    try {
+      await openProvidersSettingsPage();
+    } finally {
+      btn.disabled = false;
+    }
+  });
+}
+
+function rebindPlannerRequestFailureControls() {
+  document.querySelectorAll('.planner-request-failure-provider-btn')
+    .forEach(bindPlannerProviderSettingsButton);
+}
+
+function renderPlannerRequestFailure(assistantEl, data, retryPayload = null) {
+  if (!assistantEl || data?.code !== 'planner_request_failed') return false;
+  const textEl = assistantEl.querySelector('.message-text');
+  if (!textEl) return false;
+  if (textEl.querySelector('.planner-request-failure-actions')) return true;
+
+  clearAssistantTextStreamState(assistantEl);
+  assistantEl.classList.add('planner-request-failure');
+  textEl.classList.add('planner-request-failure-content');
+  textEl.replaceChildren();
+
+  const message = document.createElement('div');
+  message.className = 'planner-request-failure-message';
+  message.textContent = data.message || 'Planner request failed before a valid response was available.';
+
+  const actions = document.createElement('div');
+  actions.className = 'planner-request-failure-actions';
+
+  const retryBtn = document.createElement('button');
+  retryBtn.type = 'button';
+  retryBtn.className = 'planner-request-failure-action planner-request-failure-retry-btn';
+  retryBtn.textContent = t('sp.retry');
+  retryBtn.title = t('sp.retry');
+  retryBtn.setAttribute('aria-label', t('sp.retry'));
+  const retryReady = configureRetryButton(retryBtn, retryPayload);
+
+  const providerBtn = document.createElement('button');
+  providerBtn.type = 'button';
+  providerBtn.className = 'planner-request-failure-action planner-request-failure-provider-btn';
+  providerBtn.textContent = t('st.tab.providers');
+  providerBtn.title = `${t('sp.btn.settings')}: ${t('st.tab.providers')}`;
+  providerBtn.setAttribute('aria-label', providerBtn.title);
+  bindPlannerProviderSettingsButton(providerBtn);
+
+  const orderedActions = data.failureKind === 'auth'
+    ? [providerBtn, retryReady ? retryBtn : null]
+    : [retryReady ? retryBtn : null, providerBtn];
+  const visibleActions = orderedActions.filter(Boolean);
+  visibleActions[0]?.classList.add('primary');
+  visibleActions.forEach(btn => actions.appendChild(btn));
+
+  textEl.append(message, actions);
+  addMessageCopyButton(assistantEl);
+  scrollToBottom();
+  return true;
+}
+
 function clearActiveChatPayloadForTab(tabId) {
   if (tabId != null) activeChatPayloadsByTab.delete(tabId);
 }
@@ -5262,6 +5346,7 @@ function rebindRestoredMessageControls() {
   rebindCopyButtons();
   rebindScreenshotSaveButtons();
   rebindRetryButtons();
+  rebindPlannerRequestFailureControls();
   rebindContinueButtons();
   rebindClarifyCards();
   rebindPlanReviewCards();
@@ -6989,6 +7074,14 @@ async function sendMessage(extraChatParams = {}) {
     accepted = true;
     completedSuccessfully = res?.successfulDone === true || updatesContainSuccessfulDone(res?.updates);
     promptEligibleCompletion = completedSuccessfully || isSuccessfulAskCompletion(modeForSend, res);
+    const returnedPlannerFailure = plannerRequestFailureUpdate(res?.updates);
+    if (returnedPlannerFailure
+        && renderToCurrentTab
+        && currentTabId === tabId
+        && !isTabAbortRequested(tabId)
+        && !clearedConversationRunRequestIds.has(requestId)) {
+      renderPlannerRequestFailure(assistantEl, returnedPlannerFailure.data, retryPayload);
+    }
     const returnedErrorUpdate = Array.isArray(res?.updates)
       ? res.updates.find(u => u?.type === 'error')
       : null;
@@ -7539,7 +7632,12 @@ function handleAgentUpdateMessage(msg) {
 
     case 'warning':
       hideActivity();
-      if (data?.code === 'ask_stream_fallback') {
+      if (data?.code === 'planner_request_failed') {
+        const targetAssistantEl = eventAssistantEl || currentAssistantEl;
+        const retryPayload = activeRetryPayloadForRequest(eventTabId, msg.requestId)
+          || retryPayloadForRunAssistant(targetAssistantEl);
+        renderPlannerRequestFailure(targetAssistantEl, data, retryPayload);
+      } else if (data?.code === 'ask_stream_fallback') {
         showComposerToast(t('sp.streaming.fallback'), { duration: 6000 });
       }
       break;

src/chrome/styles/sidepanel.css

@@ -2861,6 +2861,72 @@ body {
   background: var(--accent-hover);
 }
 
+/* Planner transport/auth failure — actionable assistant card */
+.message.assistant.planner-request-failure .message-content {
+  background: rgba(244, 67, 54, 0.08);
+  border-color: rgba(244, 67, 54, 0.3);
+}
+
+.planner-request-failure-content {
+  display: flex;
+  flex-direction: column;
+  gap: 10px;
+}
+
+.planner-request-failure-message {
+  color: var(--error-soft);
+}
+
+.planner-request-failure-actions {
+  display: flex;
+  flex-wrap: wrap;
+  gap: 7px;
+}
+
+.planner-request-failure-action {
+  min-height: 30px;
+  padding: 5px 11px;
+  border: 1px solid rgba(244, 67, 54, 0.35);
+  border-radius: 6px;
+  background: rgba(244, 67, 54, 0.06);
+  color: var(--error-soft);
+  font: inherit;
+  font-size: 12px;
+  font-weight: 600;
+  cursor: pointer;
+  transition: background 0.15s, border-color 0.15s, color 0.15s;
+}
+
+.planner-request-failure-action.primary {
+  border-color: var(--accent);
+  background: var(--accent);
+  color: #fff;
+}
+
+.planner-request-failure-action:hover:not(:disabled),
+.planner-request-failure-action:focus-visible {
+  border-color: rgba(244, 67, 54, 0.6);
+  background: rgba(244, 67, 54, 0.16);
+  color: var(--text-primary);
+}
+
+.planner-request-failure-action.primary:hover:not(:disabled),
+.planner-request-failure-action.primary:focus-visible {
+  border-color: var(--accent-hover);
+  background: var(--accent-hover);
+  color: #fff;
+}
+
+.planner-request-failure-action:focus-visible {
+  outline: 2px solid var(--accent);
+  outline-offset: 2px;
+}
+
+.planner-request-failure-action:disabled {
+  cursor: wait;
+  opacity: 0.65;
+}
+
 /* Error messages */
 .message.error .message-content {
   background: rgba(244, 67, 54, 0.1);