Announce the planner failure card and stop duplicating its Retry

Three loose ends around the recovery card: `addErrorRetryButton` only
looked for the error and cost-allowance classes, so a message that also
took an error update could grow a second Retry affordance next to the
card's own; the reconnect path recomputed a fallback that its own
`assistantEl` already applied; and the card said nothing to a screen
reader. The role goes on the emptied container before its content, since
readers announce insertions into a live region rather than a region that
shows up already populated — which also keeps a restored card silent.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: esokullu

src/chrome/src/ui/sidepanel.js

@@ -3740,11 +3740,10 @@ async function adoptRestoredRunState(tabId, state) {
     });
     const returnedPlannerFailure = plannerRequestFailureUpdate(res?.updates);
     if (returnedPlannerFailure && sameTabId(currentTabId, tabId) && !isTabAbortRequested(tabId)) {
-      const targetAssistantEl = assistantEl || currentAssistantEl;
       renderPlannerRequestFailure(
-        targetAssistantEl,
+        assistantEl,
         returnedPlannerFailure.data,
-        retryPayloadForRunAssistant(targetAssistantEl),
+        retryPayloadForRunAssistant(assistantEl),
       );
     }
     const returnedErrorUpdate = Array.isArray(res?.updates)
@@ -5251,6 +5250,10 @@ function renderPlannerRequestFailure(assistantEl, data, retryPayload = null) {
   assistantEl.classList.add('planner-request-failure');
   textEl.classList.add('planner-request-failure-content');
   textEl.replaceChildren();
+  // Set the role on the empty container first: screen readers announce
+  // content inserted into an existing live region, not a region that arrives
+  // already populated. A restored card stays silent, which is what we want.
+  textEl.setAttribute('role', 'alert');
 
   const message = document.createElement('div');
   message.className = 'planner-request-failure-message';
@@ -8860,7 +8863,8 @@ function configureRetryButton(btn, retryPayload) {
 }
 
 function addErrorRetryButton(msgEl, retryPayload) {
-  if (!msgEl || !retryPayload?.text || msgEl.querySelector('.error-retry-btn, .cost-allowance-retry-btn')) return;
+  if (!msgEl || !retryPayload?.text
+      || msgEl.querySelector('.error-retry-btn, .cost-allowance-retry-btn, .planner-request-failure-retry-btn')) return;
   msgEl.classList.add('retryable');
   const btn = document.createElement('button');
   btn.type = 'button';

src/firefox/src/ui/sidepanel.js

@@ -3589,11 +3589,10 @@ async function adoptRestoredRunState(tabId, state) {
     });
     const returnedPlannerFailure = plannerRequestFailureUpdate(res?.updates);
     if (returnedPlannerFailure && sameTabId(currentTabId, tabId) && !isTabAbortRequested(tabId)) {
-      const targetAssistantEl = assistantEl || currentAssistantEl;
       renderPlannerRequestFailure(
-        targetAssistantEl,
+        assistantEl,
         returnedPlannerFailure.data,
-        retryPayloadForRunAssistant(targetAssistantEl),
+        retryPayloadForRunAssistant(assistantEl),
       );
     }
     const returnedErrorUpdate = Array.isArray(res?.updates)
@@ -5088,6 +5087,10 @@ function renderPlannerRequestFailure(assistantEl, data, retryPayload = null) {
   assistantEl.classList.add('planner-request-failure');
   textEl.classList.add('planner-request-failure-content');
   textEl.replaceChildren();
+  // Set the role on the empty container first: screen readers announce
+  // content inserted into an existing live region, not a region that arrives
+  // already populated. A restored card stays silent, which is what we want.
+  textEl.setAttribute('role', 'alert');
 
   const message = document.createElement('div');
   message.className = 'planner-request-failure-message';
@@ -8506,7 +8509,8 @@ function configureRetryButton(btn, retryPayload) {
 }
 
 function addErrorRetryButton(msgEl, retryPayload) {
-  if (!msgEl || !retryPayload?.text || msgEl.querySelector('.error-retry-btn, .cost-allowance-retry-btn')) return;
+  if (!msgEl || !retryPayload?.text
+      || msgEl.querySelector('.error-retry-btn, .cost-allowance-retry-btn, .planner-request-failure-retry-btn')) return;
   msgEl.classList.add('retryable');
   const btn = document.createElement('button');
   btn.type = 'button';

test/run.js

@@ -49737,6 +49737,16 @@ test('planner request failures expose provider settings and retry actions in bot
       /if \(data\.provider\) \{[\s\S]*?providerName\.className = 'planner-request-failure-provider';[\s\S]*?providerName\.textContent = data\.provider;/,
       `${label}: the failing provider is never named, so "open Providers" does not say which one to fix`,
     );
+    assert.match(
+      panel,
+      /textEl\.replaceChildren\(\);[\s\S]*?textEl\.setAttribute\('role', 'alert'\);[\s\S]*?const message = document\.createElement\('div'\);/,
+      `${label}: the failure card is not announced, and the role must precede its content to be spoken`,
+    );
+    assert.match(
+      panel,
+      /msgEl\.querySelector\('\.error-retry-btn, \.cost-allowance-retry-btn, \.planner-request-failure-retry-btn'\)/,
+      `${label}: a planner failure card can be given a second, duplicate Retry affordance`,
+    );
     assert.match(css, /\.planner-request-failure-actions \{/, `${label}: planner failure action row is not styled`);
     assert.match(css, /\.planner-request-failure-action\.primary \{/, `${label}: planner failure primary action is not styled`);
     assert.match(css, /\.planner-request-failure-provider \{/, `${label}: planner failure provider label is not styled`);