Fix changelog and 23.0.0 release archives

Author: esokullu

CHANGELOG.md

@@ -20,24 +20,18 @@
  *   dist/webbrain-edge-<version>.zip
  *   dist/webbrain-firefox-<version>.zip
  *
- * <version> is read from package.json so a single npm-version bump
- * cascades into the right filenames.
+ * <version> is read from package.json at HEAD, and every archived manifest
+ * must match it. An uncommitted version bump is rejected instead of creating
+ * a new-looking filename around an old manifest.
  */
 
 import { readFileSync, mkdirSync } from 'node:fs';
 import { execFileSync } from 'node:child_process';
-import { fileURLToPath } from 'node:url';
+import { fileURLToPath, pathToFileURL } from 'node:url';
 import path from 'node:path';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const root = path.resolve(__dirname, '..');
-const pkg = JSON.parse(readFileSync(path.join(root, 'package.json'), 'utf8'));
-const version = pkg.version;
-
-const distDir = path.join(root, 'dist');
-mkdirSync(distDir, { recursive: true });
-
-console.log(`Building extension zips for v${version} …`);
 
 const targets = [
   { packageName: 'chrome', sourceDir: 'chrome' },
@@ -46,14 +40,58 @@ const targets = [
   { packageName: 'firefox', sourceDir: 'firefox' },
 ];
 
-for (const { packageName, sourceDir } of targets) {
-  const out = path.join(distDir, `webbrain-${packageName}-${version}.zip`);
-  // -o writes directly to the file; avoids needing shell redirection,
-  // so this runs identically on bash, zsh, cmd, and PowerShell.
-  execFileSync(
-    'git',
-    ['archive', '--format=zip', '-o', out, `HEAD:src/${sourceDir}`],
-    { stdio: 'inherit', cwd: root }
+export function assertMatchingArchiveVersion(expected, actual, label) {
+  if (actual !== expected) {
+    throw new Error(`${label} is ${actual}, but the release package version is ${expected}.`);
+  }
+}
+
+function readJsonAtHead(relativePath) {
+  const json = execFileSync('git', ['show', `HEAD:${relativePath}`], {
+    cwd: root,
+    encoding: 'utf8',
+    stdio: ['ignore', 'pipe', 'pipe'],
+  });
+  return JSON.parse(json);
+}
+
+function runCli() {
+  const workingPackage = JSON.parse(readFileSync(path.join(root, 'package.json'), 'utf8'));
+  const headPackage = readJsonAtHead('package.json');
+  assertMatchingArchiveVersion(
+    headPackage.version,
+    workingPackage.version,
+    'Working-tree package.json version'
   );
-  console.log(`  ✓ dist/webbrain-${packageName}-${version}.zip`);
+
+  const version = headPackage.version;
+  for (const { sourceDir } of targets) {
+    const manifest = readJsonAtHead(`src/${sourceDir}/manifest.json`);
+    assertMatchingArchiveVersion(version, manifest.version, `HEAD src/${sourceDir}/manifest.json version`);
+  }
+
+  const distDir = path.join(root, 'dist');
+  mkdirSync(distDir, { recursive: true });
+  console.log(`Building extension zips for v${version} from HEAD …`);
+
+  for (const { packageName, sourceDir } of targets) {
+    const out = path.join(distDir, `webbrain-${packageName}-${version}.zip`);
+    // -o writes directly to the file; avoids needing shell redirection,
+    // so this runs identically on bash, zsh, cmd, and PowerShell.
+    execFileSync(
+      'git',
+      ['archive', '--format=zip', '-o', out, `HEAD:src/${sourceDir}`],
+      { stdio: 'inherit', cwd: root }
+    );
+    console.log(`  ✓ dist/webbrain-${packageName}-${version}.zip`);
+  }
+}
+
+if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {
+  try {
+    runCli();
+  } catch (error) {
+    console.error(`build-zip: ${error.message}`);
+    process.exit(1);
+  }
 }

dist/webbrain-chrome-23.0.0.zip

@@ -266,6 +266,9 @@ const { bumpSemver, rewriteVersionInJsonText, rewriteVersionByAnchor, isReleaseB
 const { normalizeChangelogBody, buildChangelogSection, insertChangelogEntry } = await import(
   'file://' + path.join(ROOT, 'scripts/update-changelog.mjs').replace(/\\/g, '/')
 );
+const { assertMatchingArchiveVersion } = await import(
+  'file://' + path.join(ROOT, 'scripts/build-zip.mjs').replace(/\\/g, '/')
+);
 
 // providers/manager.js — pure ESM at module load (chrome.* only inside
 // methods). We import the class so we can exercise the static categoryFor()
@@ -3342,6 +3345,11 @@ All notable changes to WebBrain are documented in this file.
   });
   assert.match(after, /^# Changelog[\s\S]*## \[1\.3\.0\] - 2026-06-28[\s\S]*## \[1\.2\.3\] - 2026-06-01/);
   assert.match(after, /### Added\n- Added a release workflow\./);
+  assert.equal(
+    after.slice(after.indexOf('## [1.2.3]')),
+    before.slice(before.indexOf('## [1.2.3]')),
+    'inserting a release must preserve the existing changelog byte-for-byte'
+  );
 });
 
 test('update-changelog: normalizes plain notes and fenced AI output', () => {
@@ -3365,6 +3373,26 @@ test('update-changelog: rejects duplicate versions and nested release headings',
   assert.throws(() => buildChangelogSection('1.4.0', '2026-06-28', '## [1.4.0] - 2026-06-28'), /must not include/);
 });
 
+test('repository changelog retains complete, non-empty release history', () => {
+  const changelog = fs.readFileSync(path.join(ROOT, 'CHANGELOG.md'), 'utf8');
+  const packageVersion = JSON.parse(fs.readFileSync(path.join(ROOT, 'package.json'), 'utf8')).version;
+  const releases = [...changelog.matchAll(/^## \[(\d+\.\d+\.\d+)\] - \d{4}-\d{2}-\d{2}$/gm)];
+  const versions = releases.map((match) => match[1]);
+
+  assert.equal(versions[0], packageVersion, 'the newest changelog entry must match package.json');
+  assert.ok(versions.length >= 100, `expected the full changelog history, found only ${versions.length} releases`);
+  assert.ok(versions.includes('0.7.0'), 'the changelog must retain its earliest documented release');
+  assert.equal(new Set(versions).size, versions.length, 'changelog release versions must be unique');
+
+  for (let i = 0; i < releases.length; i += 1) {
+    const bodyStart = releases[i].index + releases[i][0].length;
+    const bodyEnd = releases[i + 1]?.index ?? changelog.length;
+    const body = changelog.slice(bodyStart, bodyEnd);
+    assert.match(body, /^### (Added|Changed|Fixed|Tests)$/m, `${versions[i]} must have a change section`);
+    assert.match(body, /^- /m, `${versions[i]} must have at least one change`);
+  }
+});
+
 test('rejects bad current version', () => {
   assert.throws(() => bumpSemver('not-a-version', 'patch'), /not MAJOR\.MINOR\.PATCH/);
   assert.throws(() => bumpSemver('1.2', 'patch'), /not MAJOR\.MINOR\.PATCH/);
@@ -3529,6 +3557,14 @@ test('submissionZipRemoveCommand tolerates missing first Edge artifact', () => {
   );
 });
 
+test('build-zip rejects filenames that would disagree with archived manifests', () => {
+  assert.doesNotThrow(() => assertMatchingArchiveVersion('23.0.0', '23.0.0', 'Chrome manifest'));
+  assert.throws(
+    () => assertMatchingArchiveVersion('23.0.0', '22.4.5', 'Chrome manifest'),
+    /Chrome manifest is 22\.4\.5, but the release package version is 23\.0\.0/
+  );
+});
+
 test('firefox manifest uses the AMO extension id', () => {
   const manifest = JSON.parse(fs.readFileSync(path.join(ROOT, 'src/firefox/manifest.json'), 'utf8'));
   assert.equal(manifest.browser_specific_settings?.gecko?.id, 'webbrain@esokullu.com');