fix: prevent watcher crash in multi-compiler mode after deleting a watched source file, #191

webdiscus · webdiscus · commit 934de27c28a8 · 2026-05-31T22:58:41.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 4.23.1 (2026-05-31)
+
+- fix: prevent watcher crash in multi-compiler mode when Webpack invalidates a compilation with a `null` filename after deleting a watched source file, #191
+
 ## 4.23.0 (2026-03-09)
 
 - feat: add per-entry override support for `js.inline`, `css.inline`, and HTML `minify` options
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "html-bundler-webpack-plugin",
-  "version": "4.23.0",
+  "version": "4.23.1",
   "description": "Generates complete single-page or multi-page website from source assets. Built-in support for Markdown, Eta, EJS, Handlebars, Nunjucks, Pug. Alternative to html-webpack-plugin.",
   "keywords": [
     "html",
diff --git a/src/Plugin/AssetCompiler.js b/src/Plugin/AssetCompiler.js
@@ -609,6 +609,8 @@ class AssetCompiler {
     const isEntry = this.assetEntry.isEntryResource(fileName);
 
     if (!isEntry) {
+      if (!this.compilation) return;
+
       const dependency = PluginService.getDependencyInstance(this.compilation.compiler);
 
       // dependency is null when no html entry defined and a style in entry was changed
diff --git a/src/Plugin/AssetEntry.js b/src/Plugin/AssetEntry.js
@@ -243,6 +243,8 @@ class AssetEntry {
    * @return {boolean}
    */
   isEntryResource(resource) {
+    if (!resource) return false;
+
     const [resourceFile] = resource.split('?', 1);
     for (let { isTemplate, sourceFile } of this.entriesByName.values()) {
       if (isTemplate && sourceFile === resourceFile) return true;
diff --git a/test/issue.test.js b/test/issue.test.js
@@ -1,3 +1,8 @@
+import fs from 'fs';
+import os from 'os';
+import path from 'path';
+import webpack from 'webpack';
+import HtmlBundlerPlugin from '../src';
 import { compareFiles } from './utils/helpers';
 
 beforeAll(() => {
@@ -19,4 +24,56 @@ describe('issue tests', () => {
   test('issue advanced template', () => compareFiles('issue-0-advanced-template'));
 
   test('issue infinity walk by circular dependency', () => compareFiles('issue-mui-css'));
+
+  test('multi compiler invalid hook handles null filename, issue #191', () => {
+    const context = fs.mkdtempSync(path.join(os.tmpdir(), 'html-bundler-webpack-plugin-'));
+    const sourcePath = path.join(context, 'src');
+
+    fs.mkdirSync(sourcePath, { recursive: true });
+    fs.writeFileSync(path.join(sourcePath, 'home.html'), '<!doctype html><script src="./home.js"></script>');
+    fs.writeFileSync(path.join(sourcePath, 'home.js'), 'console.log("home");');
+    fs.writeFileSync(path.join(sourcePath, 'about.html'), '<!doctype html><script src="./about.js"></script>');
+    fs.writeFileSync(path.join(sourcePath, 'about.js'), 'console.log("about");');
+
+    try {
+      const compiler = webpack([
+        {
+          name: 'home',
+          mode: 'development',
+          context,
+          output: {
+            path: path.join(context, 'dist/home'),
+          },
+          plugins: [
+            new HtmlBundlerPlugin({
+              entry: {
+                home: './src/home.html',
+              },
+            }),
+          ],
+        },
+        {
+          name: 'about',
+          mode: 'development',
+          context,
+          output: {
+            path: path.join(context, 'dist/about'),
+          },
+          plugins: [
+            new HtmlBundlerPlugin({
+              entry: {
+                about: './src/about.html',
+              },
+            }),
+          ],
+        },
+      ]);
+
+      for (const childCompiler of compiler.compilers) {
+        expect(() => childCompiler.hooks.invalid.call(null, null)).not.toThrow();
+      }
+    } finally {
+      fs.rmSync(context, { recursive: true, force: true });
+    }
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "html-bundler-webpack-plugin",`
`3`		`- "version": "4.23.0",`
	`3`	`+ "version": "4.23.1",`
`4`	`4`	`"description": "Generates complete single-page or multi-page website from source assets. Built-in support for Markdown, Eta, EJS, Handlebars, Nunjucks, Pug. Alternative to html-webpack-plugin.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"html",`