fix: stripComments handles RegExp literals (#180)#181
Merged
webdiscus merged 3 commits intowebdiscus:masterfrom Jul 2, 2025
Merged
fix: stripComments handles RegExp literals (#180)#181webdiscus merged 3 commits intowebdiscus:masterfrom
webdiscus merged 3 commits intowebdiscus:masterfrom
Conversation
Owner
|
Thanks for your contribution! I have added tests for stripComments.test.js. Can you please add your tests for RegExp? |
Contributor
Author
|
Added the RegExp tests—everything passes locally. |
Owner
|
Thank you for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
This PR contains a:
Motivation / Use-Case
This PR fixes a bug in the
stripCommentsfunction, which incorrectly treated comment-like syntax (//,/* */)inside regular expressions as actual comments. This led to invalid output JS when processing
.hbstemplates withhelper files containing such patterns.
Example that caused the error:
In large projects, this resulted in:
This PR resolves #180 by improving the parsing logic
to recognize and correctly skip over RegExp literals, including those containing
//,/*, and character classes.Breaking Changes
None.
Additional Info
This is my first detailed pull request — I hope everything is correct!
Let me know if anything needs to be changed — happy to fix it.
Checklist
Appreciation for the useful project