This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Wrap debug command to ensure mocha timeout not triggered#118
Open
jaridmargolin wants to merge 1 commit into
Open
Wrap debug command to ensure mocha timeout not triggered#118jaridmargolin wants to merge 1 commit into
jaridmargolin wants to merge 1 commit into
Conversation
|
|
Author
|
@christian-bromann any chance you could give this a quick look? This fixes the very annoying issue of needing to set the timeout each time you need to use a debug statement. |
Contributor
|
Hey, yeah this would be very helpful. We should be consistent with Jasmine and Cucumber and apply the same change there too. |
Author
|
Ok... I have a little less familiarity with these two runners, but I'll give it a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not the final implementation (missing tests), but wanted to open a quick PR to discuss if this would conceptually be considered for merge.