fix: version cached binary filename to detect stale/mismatched drivers#733
Merged
christian-bromann merged 1 commit intoJul 2, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the geckodriver installer to avoid stale/mismatched cached binaries by incorporating the resolved version into the cached binary filename, and adds tests around caching and staging-directory behavior.
Changes:
- Add
getBinaryFilename(version)and switch cache lookup/output to versioned filenames. - Introduce per-download staging directories (
mkdtemp) to avoid shared intermediate extraction paths. - Expand unit tests to cover versioned filenames and caching hot paths (including “no network when cached”).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/install.ts |
Versioned cache paths, staging-directory extraction, and final rename into versioned binary name. |
tests/unit.test.ts |
New unit tests and module-scope mocks to validate versioned filenames and caching/staging behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mccmrunal
force-pushed
the
fix/versioned-binary-cache-731
branch
from
6e56751 to
6db383b
Compare
christian-bromann
approved these changes
Jul 2, 2026
christian-bromann
merged commit 6e24754
into
webdriverio-community:main
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#731