chore: updated beforeScreenshot

- fixed and added UT's

Author: wswebcreation

packages/image-comparison-core/src/commands/saveFullPageScreen.ts

@@ -60,7 +60,7 @@ export default async function saveFullPageScreen(
         toolBarShadowPadding,
         waitForFontsLoaded,
     }
-    const enrichedInstanceData: BeforeScreenshotResult = await beforeScreenshot(methods.executor, beforeOptions, true)
+    const enrichedInstanceData: BeforeScreenshotResult = await beforeScreenshot(beforeOptions, true)
     const {
         browserName,
         browserVersion,

packages/image-comparison-core/src/commands/saveWebElement.ts

@@ -53,7 +53,7 @@ export default async function saveWebElement(
         toolBarShadowPadding,
         waitForFontsLoaded,
     }
-    const enrichedInstanceData: BeforeScreenshotResult = await beforeScreenshot(executor, beforeOptions, true)
+    const enrichedInstanceData: BeforeScreenshotResult = await beforeScreenshot(beforeOptions, true)
     const {
         browserName,
         browserVersion,

packages/image-comparison-core/src/commands/saveWebScreen.ts

@@ -49,7 +49,7 @@ export default async function saveWebScreen(
         toolBarShadowPadding,
         waitForFontsLoaded,
     }
-    const enrichedInstanceData: BeforeScreenshotResult = await beforeScreenshot(methods.executor, beforeOptions)
+    const enrichedInstanceData: BeforeScreenshotResult = await beforeScreenshot(beforeOptions)
     const {
         browserName,
         browserVersion,

packages/image-comparison-core/src/helpers/__snapshots__/beforeScreenshot.test.ts.snap

@@ -2,146 +2,24 @@
 
 exports[`beforeScreenshot > should be able to return the enriched instance data with \`addShadowPadding: true\` 1`] = `
 {
-  "addressBarShadowPadding": 0,
-  "appName": "appName",
-  "browserName": "browserName",
-  "browserVersion": "browserVersion",
-  "deviceName": "deviceName",
+  "appName": "mocked-app",
+  "browserName": "mocked-browser",
   "devicePixelRatio": 1,
-  "deviceRectangles": {
-    "bottomBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "homeBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "leftSidePadding": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "rightSidePadding": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "screenSize": {
-      "height": 1,
-      "width": 1,
-    },
-    "statusBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "statusBarAndAddressBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "viewport": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-  },
-  "initialDevicePixelRatio": 1,
   "isAndroid": false,
-  "isAndroidChromeDriverScreenshot": false,
-  "isAndroidNativeWebScreenshot": false,
   "isIOS": false,
   "isMobile": false,
-  "isTestInBrowser": true,
-  "isTestInMobileBrowser": false,
-  "logName": "logName",
-  "name": "name",
-  "nativeWebScreenshot": false,
-  "platformName": "platformName",
-  "platformVersion": "platformVersion",
-  "toolBarShadowPadding": 0,
+  "platformName": "mocked-platform",
 }
 `;
 
 exports[`beforeScreenshot > should be able to return the enriched instance data with default options 1`] = `
 {
-  "addressBarShadowPadding": 0,
-  "appName": "appName",
-  "browserName": "browserName",
-  "browserVersion": "browserVersion",
-  "deviceName": "deviceName",
+  "appName": "mocked-app",
+  "browserName": "mocked-browser",
   "devicePixelRatio": 1,
-  "deviceRectangles": {
-    "bottomBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "homeBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "leftSidePadding": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "rightSidePadding": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "screenSize": {
-      "height": 1,
-      "width": 1,
-    },
-    "statusBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "statusBarAndAddressBar": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-    "viewport": {
-      "height": 0,
-      "width": 0,
-      "x": 0,
-      "y": 0,
-    },
-  },
-  "initialDevicePixelRatio": 1,
   "isAndroid": false,
-  "isAndroidChromeDriverScreenshot": false,
-  "isAndroidNativeWebScreenshot": false,
   "isIOS": false,
   "isMobile": false,
-  "isTestInBrowser": true,
-  "isTestInMobileBrowser": false,
-  "logName": "logName",
-  "name": "name",
-  "nativeWebScreenshot": false,
-  "platformName": "platformName",
-  "platformVersion": "platformVersion",
-  "toolBarShadowPadding": 0,
+  "platformName": "mocked-platform",
 }
 `;