Skip to content

fix: prevent false emulation detection inside iframe context#1155

Merged
wswebcreation merged 3 commits into
webdriverio:mainfrom
n2-freevas:fix/iframe-emulation-false-positive
Jun 23, 2026
Merged

fix: prevent false emulation detection inside iframe context#1155
wswebcreation merged 3 commits into
webdriverio:mainfrom
n2-freevas:fix/iframe-emulation-false-positive

Conversation

@n2-freevas

@n2-freevas n2-freevas commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

for : #1156

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f3b8716

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@wdio/image-comparison-core Patch
@wdio/visual-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 16, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: n2-freevas / name: Taro.Nonoyama (7d690e2)

@wswebcreation

Copy link
Copy Markdown
Member

@n2-freevas

Thanks for teh PR, can you please sign the CLA? We can then release it

@n2-freevas n2-freevas marked this pull request as ready for review June 17, 2026 00:35
@n2-freevas

Copy link
Copy Markdown
Contributor Author

@wswebcreation

I signed the CLA 👍

@n2-freevas

Copy link
Copy Markdown
Contributor Author

@wswebcreation
Hi,
Just following up on the PR below.
Could you take a look when you have a moment?

Comment thread .changeset/fix-iframe-emulation.md
Fixes the issue of false emulation detection when checkElement is called inside an iframe after switching frames.

@wswebcreation wswebcreation left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Wil merge and release it today

@wswebcreation wswebcreation merged commit 60997df into webdriverio:main Jun 23, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants