Skip to content

fix(deps-dev): drop usage of @ciscospark/test-users-legacy dependency#4515

Closed
toretre wants to merge 1 commit into
webex:masterfrom
toretre:master
Closed

fix(deps-dev): drop usage of @ciscospark/test-users-legacy dependency#4515
toretre wants to merge 1 commit into
webex:masterfrom
toretre:master

Conversation

@toretre
Copy link
Copy Markdown
Contributor

@toretre toretre commented Oct 2, 2025

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

It seems the '@ciscospark/test-users-legacy' is only referenced by 'internal-plugin-lyra' and there only for a utility method to generate a random string.
'@ciscospark/test-users-legacy' is an old dependency and might block dependency upgrades for consuming project like dependency 'requests' which abandoned and also have many CVE vulnerabilities attached.

by making the following changes

< DESCRIBE YOUR CHANGES >

  1. Copy helper method to generate random string from '@ciscospark/test-users-legacy' to '@webex/test-helper-test-users/src/index.js'. Changed internal-plugin-lyra to use this moved method.
  2. Drop '@ciscospark/test-users-legacy' from the package.json files where it is referenced

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@toretre toretre closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant