test(calling): add transfer consult flows#4939
test(calling): add transfer consult flows#4939eigengravy wants to merge 3 commits intowebex:nextfrom
Conversation
- Target visible incoming #answer via #incomingsection scope to avoid the hidden duplicate in the sample app - Make cleanupActiveCalls retry-capable with a direct call.end() fallback, and invoke it before context teardown - Fix withTimeout to clear its timer on settle so promises do not leak handles - Tolerate resumeCall being entered from either Hold or Resume state - Guard unregisterLine against closed pages / already-unregistered state, and wait for "Unregistered" rather than "Un registering"
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
eigengravy
changed the title
Enable the SET_3USER Playwright projects (PROD + INT) and add the transfer/consult test group that runs against them. Picks up the checkpoint that was lost during an earlier reset + rebase. - packages/calling/playwright.config.ts: enable SET_3USER projects - packages/calling/playwright/suites/set-3user.spec.ts: suite entry - packages/calling/playwright/test-groups/transfer-tests.ts: blind and consult transfer flows
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c019e875a1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Page may have closed during teardown | ||
| } | ||
| }); | ||
| test.afterAll(() => group.teardown()); |
There was a problem hiding this comment.
setupThreeUserGroup() returns setup, cleanupAfterEach, and getters, but no teardown method, so test.afterAll(() => group.teardown()) throws TypeError: group.teardown is not a function when this describe finishes. That causes this suite to fail during teardown and skips the intended final cleanup path for the shared 3-user contexts.
Useful? React with 👍 / 👎.
1 participant
COMPLETES https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7882
This pull request addresses
Follow-up to #4879 — adds 3-user transfer & consult call-flow Playwright E2E
coverage for the Calling SDK on top of the existing 2-user suite, and hardens
call cleanup / selectors that surfaced while iterating on the new flows.
by making the following changes
SET_3USER - PRODandSET_3USER - INTPlaywright projects (depend onSET_2USER)suites/set-3user.spec.tsas the 3-user suite entry pointtest-groups/transfer-tests.tswith blind transfer and consult transfer flowstest-manager.tsandutils/call.tsto support 3-user call flows#incomingsectionto avoid the hidden duplicate in the sample appcleanupActiveCallsretry-capable with a directcall.end()fallback, invoked before context teardownwithTimeoutto clear its timer on settle so promises do not leak handlesresumeCallbeing entered from either Hold or Resume stateunregisterLineagainst closed pages / already-unregistered state and waits forUnregisteredChange Type
The following scenarios were tested
SET_3USER - PROD/SET_3USER - INTThe GAI Coding Policy And Copyright Annotation Best Practices
I certified that