refactor(internal-plugin-encryption): pkijs v3 + node 20 engines#4951
Open
Tiuipuv wants to merge 2 commits intowebex:nextfrom
Open
refactor(internal-plugin-encryption): pkijs v3 + node 20 engines#4951Tiuipuv wants to merge 2 commits intowebex:nextfrom
Tiuipuv wants to merge 2 commits intowebex:nextfrom
Conversation
update pkijs to v3, and fix call points remove asn1js (using new pkijs features) remove valid-url (use native URL constructor) remove isomorphic-webcrypto (use new pkijs features) remove safe-buffer (use native Buffer constructor) remove uuid (use native uuid v4 via global crypto) fix jsdocs
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses
Reduce the size of the dependency tree massively (which will allow consumers to remove
--omit=optionalfrom npm installs) due to the entire expo/react native tree being installed.Before, when running
npm install webex-js-sdkin a fresh directory will yield this:With this fix branch, it will yield this:
Lastly, this branch standardizes node ver to >=20 (up from ~18)
by making the following changes
This is done by removing deps in
internal-plugin-encryptionthat are only used by that package, and are replaced with built-in functionality of modern browsers + nodejs.The following deps are removed:
The following were updated:
v2.1.84tov3.4.0Also, this standardizes minimum NodeJS by addressing old
engines.nodefields stuck at v8, v14, v16, and v18, bumping up to v20. Similar to #4288Change Type
The following scenarios were tested
Ran unit tests, and attempted manual bad path injection to verify code coverage of kms.
For reviewing speed purposes, the actual logic changes occur just under
internal-plugin-encryption, with the following files:The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.