feat(meetings): add site preferences API#4953
Closed
chrisadubois wants to merge 1 commit intonextfrom
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #N/A
No linked SDK issue. This supports the Webex Web Client webinar scheduling work by adding the SDK interface that WWC can consume after this PR ships.
This pull request addresses
Webex Web Client currently constructs the appapi site-preferences request itself to read
scheduling.supportScheduleWebinarandscheduling.webinarWebLink. The SDK hasgetMeetingPreferences(), but that is the existing Hydra preferred-site flow and does not expose the site-scoped appapi preferences payload.by making the following changes
webex.meetings.fetchSitePreferencesMeViaSite(selectOptions?)at the plugin-meetingsMeetingslevel.MeetingRequest#fetchSitePreferencesMeViaSite(siteUrl, selectOptions?)forGET https://{siteUrl}/wbxappapi/v1/users/me/preference.selectOptionsto['scheduling'], while allowing callers to pass a different string-array selection.MeetingsUtil.getSiteName()using the same site-name behavior as WWC, including.my.Webex sites.getMeetingPreferences()preferred-site flow unchanged..my.webex.comsite-name derivation, request error propagation,getSiteName, and the existing preferred-site regression path.Change Type
The following scenarios were tested
yarn test:unit --packages @webex/plugin-meetings --grep 'fetchSitePreferencesMeViaSite|getSiteName|fetchUserPreferredWebexSite' --no-serve— 27 passing.yarn run --silent eslint packages/@webex/plugin-meetings/src/meetings/request.ts packages/@webex/plugin-meetings/src/meetings/index.ts packages/@webex/plugin-meetings/src/meetings/meetings.types.ts packages/@webex/plugin-meetings/src/meetings/util.ts— 0 errors, existing warnings inmeetings/index.ts.git diff --check— passed.Notes:
yarn workspace @webex/plugin-meetings buildis currently blocked by an existing unrelated type error innode_modules/@webex/internal-plugin-metrics/src/call-diagnostic/config.tsforLargeScaleWebinar.The GAI Coding Policy And Copyright Annotation Best Practices
I certified that