Skip to content

feat(meetings): add site preferences API#4955

Merged
chrisadubois merged 3 commits intowebex:nextfrom
chrisadubois:meetings-site-preferences-api
May 6, 2026
Merged

feat(meetings): add site preferences API#4955
chrisadubois merged 3 commits intowebex:nextfrom
chrisadubois:meetings-site-preferences-api

Conversation

@chrisadubois
Copy link
Copy Markdown
Collaborator

@chrisadubois chrisadubois commented May 6, 2026

COMPLETES #N/A

No public Jira/link; SDK support needed for the Webex Web Client webinar scheduling dropdown migration.

This pull request addresses

Web clients currently need to fetch site-scoped appapi preferences to determine scheduling capabilities such as webinar scheduler support. Without an SDK API, consumers have to construct the /wbxappapi/v1/users/me/preference URL themselves.

by making the following changes

  • Adds webex.meetings.fetchSitePreferencesMeViaSite(options?) as an additive meetings API.
  • Adds request-layer handling for the site appapi preferences endpoint with default scheduling select options.
  • Adds configurable multipart site-name derivation through meetings.multipartSitePrefixList.
  • Adds focused unit coverage for public API delegation, request URI construction, missing-site errors, custom select/site-name overrides, config-driven multipart site names, and existing preferred-site behavior.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

unit tests

local link
Screenshot 2026-05-05 at 7 41 41 PM
Screenshot 2026-05-05 at 7 41 37 PM

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

⚠️ AI Assisted Content 🤖

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@chrisadubois chrisadubois added the validated If the pull request is validated for automation. label May 6, 2026
@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4955.d3m3l2kee0btzx.amplifyapp.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@chrisadubois chrisadubois marked this pull request as ready for review May 6, 2026 17:20
@chrisadubois chrisadubois requested review from a team as code owners May 6, 2026 17:20
@chrisadubois chrisadubois enabled auto-merge (squash) May 6, 2026 17:20
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

return this.request({
method: HTTP_VERBS.GET,
uri: `https://${siteUrl}/wbxappapi/v1/users/me/preference?select=${encodeURIComponent(
selectOptions.join(',')
)}&siteurl=${encodeURIComponent(siteName)}`,

P2 Badge Whitelist override site before issuing direct URI request

This new path uses a raw uri to https://${siteUrl}/... but never whitelists siteUrl when callers override it. In environments where broad commercial allowlists are not injected (notably FedRAMP), the auth interceptor only attaches tokens for catalog/allowed domains, so an override site that is not already in allowedDomains can return 401 even with valid input. That breaks the advertised non-preferred-site behavior; add the override host to the allowed-domain catalog (or resolve through a catalog service) before calling this.request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@chrisadubois chrisadubois merged commit ae25857 into webex:next May 6, 2026
12 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🎉 Your changes are now available!
Released in: v3.12.0-next.66
📖 View full changelog →
Packages Updated Version
webex 3.12.0-next.66
@webex/plugin-meetings 3.12.0-next.50

Thank you for your contribution!
🤖 This is an automated message. For queries, please contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants