feat(webex): add first-party authentication support for UMD bundle#5077
Open
ursnj wants to merge 5 commits into
Open
feat(webex): add first-party authentication support for UMD bundle#5077ursnj wants to merge 5 commits into
ursnj wants to merge 5 commits into
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We use ESM based front end application with Webex CDN for Metrics and Device registration, Now we need to add authentication through Webex, But when we are trying to integrate same we are getting multiple issues with CJS and ESM support and
@webex/plugin-authorization-browser-first-partyplugin support with existing CDN.We are not really sure about replacing exisitng auth with first party auth in main bundle and doing that may break existing users, So This PR adds a separate first-party Webex UMD/CDN bundle while preserving the existing
webex.min.jsbundle as is.Changes
packages/webex/src/.webex-first-partywebpack entry.@webex/plugin-authorization-browser-first-partyas awebexworkspace dependency.umd/webex-first-party.min.jsand source map for npm/CDN publishing.Validation
yarn install --immutableyarn workspace webex build:srcyarn workspace webex test:styleyarn run build:scriptyarn workspace webex pack --dry-runtest:stylepassed with existing warnings and no errors. The package dry-run includesumd/webex-first-party.min.jsandumd/webex-first-party.min.js.map.