Skip to content

fix: display hints are sometimes wrong#5087

Merged
marcin-bazyl merged 3 commits into
webex:nextfrom
marcin-bazyl:sprk-832255
Jul 9, 2026
Merged

fix: display hints are sometimes wrong#5087
marcin-bazyl merged 3 commits into
webex:nextfrom
marcin-bazyl:sprk-832255

Conversation

@marcin-bazyl

@marcin-bazyl marcin-bazyl commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

COMPLETES #SPARK-832255

This pull request addresses

display hints are sometimes not recalculated when only the self state changes

by making the following changes

make sure they're recalculated, requires 2 fixes:

  1. in LocusInfo.init()
  2. in updateMeetingInfo()

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

unit tests

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

);
}
this.roles = roles;
this.isJoined = isJoined;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like having this new flag and updating it here

@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5087.d3m3l2kee0btzx.amplifyapp.com

@marcin-bazyl marcin-bazyl marked this pull request as ready for review July 9, 2026 11:57
@marcin-bazyl marcin-bazyl requested review from a team as code owners July 9, 2026 11:57
@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Jul 9, 2026

@dominiccarrington dominiccarrington left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Able to reproduce the bug in the same meeting on production and it is fixed when joining the meeting with this PR

@github-actions github-actions Bot removed the validated If the pull request is validated for automation. label Jul 9, 2026
@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Jul 9, 2026
@marcin-bazyl marcin-bazyl merged commit c3115db into webex:next Jul 9, 2026
11 checks passed
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
🎉 Your changes are now available!
Released in: v3.12.0-next.136
📖 View full changelog →
Packages Updated Version
webex 3.12.0-next.136
@webex/plugin-meetings 3.12.0-next.92

Thank you for your contribution!
🤖 This is an automated message. For queries, please contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants