fix: display hints are sometimes wrong#5087
Merged
Merged
Conversation
marcin-bazyl
commented
Jul 8, 2026
| ); | ||
| } | ||
| this.roles = roles; | ||
| this.isJoined = isJoined; |
Collaborator
Author
There was a problem hiding this comment.
I don't like having this new flag and updating it here
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
dominiccarrington
approved these changes
Jul 9, 2026
dominiccarrington
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Able to reproduce the bug in the same meeting on production and it is fixed when joining the meeting with this PR
lismith2-cisco
approved these changes
Jul 9, 2026
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-832255
This pull request addresses
display hints are sometimes not recalculated when only the self state changes
by making the following changes
make sure they're recalculated, requires 2 fixes:
Change Type
The following scenarios were tested
unit tests
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.