fix(metrics): move @webex/event-dictionary-ts to a dependency#5089
fix(metrics): move @webex/event-dictionary-ts to a dependency#5089cmullenx wants to merge 1 commit into
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3856cbd8f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "files": [ | ||
| "dist" | ||
| ], |
There was a problem hiding this comment.
This package still leaves @webex/event-dictionary-ts only in devDependencies; adding files does not make it available to downstream installs. Because src/metrics.types.ts imports types from that package and those types are re-exported from src/index.ts, the generated dist/types declarations for published consumers can reference a package that is not installed, so TypeScript users of @webex/internal-plugin-metrics still hit the missing-module failure this change is meant to fix.
Useful? React with 👍 / 👎.
| "files": [ | ||
| "dist" | ||
| ], |
There was a problem hiding this comment.
This package still leaves @webex/event-dictionary-ts only in devDependencies; adding files does not make it available to downstream installs. src/meeting/index.ts exposes a method typed with RawClientEvent['userType'], so the generated declarations can reference @webex/event-dictionary-ts for consumers of the published package, but npm will not install this dev dependency transitively, leaving the original missing-module/type-resolution failure unresolved.
Useful? React with 👍 / 👎.
… files field The published .d.ts type declarations in dist/types/ import from @webex/event-dictionary-ts. When this package is only in devDependencies, it is not installed for consumers, causing TS2307 build failures for any downstream TypeScript project — regardless of skipLibCheck setting. This reverts the dependency classification from PR webex#4710 which incorrectly moved it to devDependencies. The generated declarations still reference the package, so it must be a production dependency. Also adds "files": ["dist"] to both packages to prevent shipping src/ and tsconfig.json in the published npm package.
2 participants
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
The build failures that occur due to @webex/event-dictionary-ts being referenced in code but only included as a dev dep
by making the following changes
added @webex/event-dictionary-ts as a dependency
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.