Skip to content

fix(metrics): move @webex/event-dictionary-ts to a dependency #5089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmullenx wants to merge 1 commit into
base: next
Choose a base branch
from
+8 −2
Open

fix(metrics): move @webex/event-dictionary-ts to a dependency #5089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/@webex/internal-plugin-metrics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"main": "dist/index.js",
"devMain": "src/index.js",
"types": "dist/types/index.d.ts",
"files": [
"dist"
],
Comment on lines +8 to +10

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add event dictionary to metrics dependencies

This package still leaves @webex/event-dictionary-ts only in devDependencies; adding files does not make it available to downstream installs. Because src/metrics.types.ts imports types from that package and those types are re-exported from src/index.ts, the generated dist/types declarations for published consumers can reference a package that is not installed, so TypeScript users of @webex/internal-plugin-metrics still hit the missing-module failure this change is meant to fix.

Useful? React with 👍 / 👎.

"repository": {
"type": "git",
"url": "https://github.com/webex/webex-js-sdk.git",
Expand All @@ -24,7 +27,6 @@
"@sinonjs/fake-timers": "^6.0.1",
"@webex/babel-config-legacy": "workspace:*",
"@webex/eslint-config-legacy": "workspace:*",
"@webex/event-dictionary-ts": "^1.0.2191",
"@webex/jest-config-legacy": "workspace:*",
"@webex/legacy-tools": "workspace:*",
"@webex/test-helper-chai": "workspace:*",
Expand All @@ -37,6 +39,7 @@
},
"dependencies": {
"@webex/common": "workspace:*",
"@webex/event-dictionary-ts": "^1.0.2191",
"@webex/common-timers": "workspace:*",
"@webex/test-helper-chai": "workspace:*",
"@webex/test-helper-mock-webex": "workspace:*",
Expand Down
5 changes: 4 additions & 1 deletion packages/@webex/plugin-meetings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"main": "dist/index.js",
"types": "dist/types/index.d.ts",
"devMain": "src/index.js",
"files": [
"dist"
],
Comment on lines +16 to +18

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add event dictionary to meetings dependencies

This package still leaves @webex/event-dictionary-ts only in devDependencies; adding files does not make it available to downstream installs. src/meeting/index.ts exposes a method typed with RawClientEvent['userType'], so the generated declarations can reference @webex/event-dictionary-ts for consumers of the published package, but npm will not install this dev dependency transitively, leaving the original missing-module/type-resolution failure unresolved.

Useful? React with 👍 / 👎.

"repository": {
"type": "git",
"url": "https://github.com/webex/webex-js-sdk.git",
Expand Down Expand Up @@ -41,7 +44,6 @@
"@types/jsdom": "^21",
"@webex/babel-config-legacy": "workspace:*",
"@webex/eslint-config-legacy": "workspace:*",
"@webex/event-dictionary-ts": "^1.0.2181",
"@webex/jest-config-legacy": "workspace:*",
"@webex/legacy-tools": "workspace:*",
"@webex/plugin-rooms": "workspace:*",
Expand All @@ -62,6 +64,7 @@
},
"dependencies": {
"@webex/common": "workspace:*",
"@webex/event-dictionary-ts": "^1.0.2181",
"@webex/internal-media-core": "2.26.1",
"@webex/internal-plugin-conversation": "workspace:*",
"@webex/internal-plugin-device": "workspace:*",
Expand Down